Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core scoped configuration & SECURED_ENV_VARIABLES #2601

Merged
merged 54 commits into from
Apr 30, 2023
Merged

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Apr 29, 2023

  • Refactor internal configuration management to scope config to a request identifier
  • New configuration variable SECURED_ENV_VARIABLES to hide some env vars from environment used when calling linters
  • Adapt node dependencies management to scoped variables

@nvuillam
Copy link
Member Author

nvuillam commented Apr 29, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.35s
✅ COPYPASTE jscpd yes no 3.26s
✅ DOCKERFILE hadolint 117 0 15.62s
✅ JSON eslint-plugin-jsonc 23 0 0 2.06s
✅ JSON jsonlint 21 0 0.18s
✅ JSON v8r 23 0 14.09s
⚠️ MARKDOWN markdownlint 313 0 232 6.59s
✅ MARKDOWN markdown-link-check 313 0 5.28s
✅ MARKDOWN markdown-table-formatter 313 0 0 20.94s
✅ OPENAPI spectral 1 0 1.31s
⚠️ PYTHON bandit 190 58 2.08s
✅ PYTHON black 190 0 0 4.11s
✅ PYTHON flake8 190 0 1.84s
✅ PYTHON isort 190 0 0 0.76s
✅ PYTHON mypy 190 0 7.24s
✅ PYTHON pylint 190 0 12.19s
⚠️ PYTHON pyright 190 288 15.53s
✅ PYTHON ruff 190 0 0 0.41s
✅ REPOSITORY checkov yes no 31.02s
✅ REPOSITORY git_diff yes no 0.35s
✅ REPOSITORY secretlint yes no 15.15s
✅ REPOSITORY trivy yes no 25.37s
✅ SPELL cspell 617 0 24.06s
⚠️ SPELL vale 222 60 39.06s
✅ XML xmllint 3 0 0 0.35s
✅ YAML prettier 157 0 0 5.09s
✅ YAML v8r 99 0 126.82s
✅ YAML yamllint 158 0 1.43s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.15s
✅ BASH shfmt 6 0 0 0.04s
✅ COPYPASTE jscpd yes no 2.62s
✅ DOCKERFILE hadolint 117 0 14.02s
✅ JSON eslint-plugin-jsonc 23 0 0 1.64s
✅ JSON jsonlint 21 0 0.18s
✅ JSON npm-package-json-lint yes no 0.59s
✅ JSON v8r 23 0 14.05s
⚠️ MARKDOWN markdownlint 313 6 232 113.82s
✅ MARKDOWN markdown-link-check 313 0 5.6s
✅ MARKDOWN markdown-table-formatter 313 6 0 15.94s
✅ OPENAPI spectral 1 0 1.22s
⚠️ PYTHON bandit 190 58 2.23s
✅ PYTHON black 190 0 0 4.17s
✅ PYTHON flake8 190 0 1.88s
✅ PYTHON isort 190 0 0 0.43s
✅ PYTHON mypy 190 0 7.96s
✅ PYTHON pylint 190 0 11.47s
⚠️ PYTHON pyright 190 288 17.56s
✅ PYTHON ruff 190 0 0 0.14s
✅ REPOSITORY checkov yes no 30.58s
⚠️ REPOSITORY devskim yes 918 4.7s
✅ REPOSITORY dustilock yes no 2.59s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 11.79s
✅ REPOSITORY syft yes no 0.99s
✅ REPOSITORY trivy yes no 26.7s
✅ SPELL cspell 630 0 23.33s
⚠️ SPELL vale 222 59 37.74s
✅ XML xmllint 3 0 0 0.02s
✅ YAML prettier 157 0 0 3.78s
✅ YAML v8r 99 0 124.98s
✅ YAML yamllint 158 0 1.53s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam changed the title WIP: Core scoped configuration Core scoped configuration & SECURED_ENV_VARIABLES Apr 30, 2023
@nvuillam nvuillam merged commit 7a78b9a into main Apr 30, 2023
@nvuillam nvuillam deleted the features/scoped-config branch April 30, 2023 18:25
and pre_post_factory.has_npm_or_yarn_commands(self.request_id)
):
workspace_node_modules = os.path.join(self.workspace, "node_modules")
copytree("/node_deps", workspace_node_modules)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will raise a FileExistsError in the common case where the workspace already contains node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants