Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkov rust compiler dependency #3007

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Remove checkov rust compiler dependency #3007

merged 1 commit into from
Oct 14, 2023

Conversation

nvuillam
Copy link
Member

No description provided.

@nvuillam nvuillam temporarily deployed to dev October 14, 2023 14:04 — with GitHub Actions Inactive
@nvuillam nvuillam temporarily deployed to dev October 14, 2023 14:04 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.03s
✅ BASH shellcheck 5 0 0.1s
✅ BASH shfmt 5 0 0 0.4s
✅ COPYPASTE jscpd yes no 3.3s
✅ DOCKERFILE hadolint 123 0 14.54s
✅ JSON eslint-plugin-jsonc 23 0 0 2.26s
✅ JSON jsonlint 21 0 0.22s
✅ JSON v8r 23 0 13.98s
✅ MAKEFILE checkmake 1 0 0.0s
⚠️ MARKDOWN markdownlint 255 0 11 5.85s
✅ MARKDOWN markdown-link-check 255 0 5.96s
✅ MARKDOWN markdown-table-formatter 255 0 0 34.92s
✅ OPENAPI spectral 1 0 1.74s
⚠️ PYTHON bandit 200 61 2.7s
✅ PYTHON black 200 0 0 4.57s
✅ PYTHON flake8 200 0 2.2s
✅ PYTHON isort 200 0 0 0.82s
✅ PYTHON mypy 200 0 10.49s
✅ PYTHON pylint 200 0 13.06s
⚠️ PYTHON pyright 200 362 20.88s
✅ PYTHON ruff 200 0 0 0.45s
✅ REPOSITORY checkov yes no 35.69s
✅ REPOSITORY git_diff yes no 0.44s
⚠️ REPOSITORY grype yes 1 10.69s
✅ REPOSITORY secretlint yes no 10.29s
✅ REPOSITORY trivy yes no 24.98s
✅ REPOSITORY trivy-sbom yes no 1.18s
⚠️ REPOSITORY trufflehog yes 1 23.32s
✅ SPELL cspell 665 0 26.15s
✅ SPELL lychee 335 0 24.26s
✅ XML xmllint 3 0 0 0.4s
✅ YAML prettier 160 0 0 5.53s
✅ YAML v8r 102 0 165.67s
✅ YAML yamllint 161 0 1.81s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 3fe7163 into main Oct 14, 2023
127 checks passed
@nvuillam nvuillam deleted the checkov-rust branch October 14, 2023 16:13
@echoix
Copy link
Collaborator

echoix commented Oct 14, 2023

The merged PR failed building a docker image with no space left ... :(

@nvuillam
Copy link
Member Author

@echoix ooooops, I check

@echoix
Copy link
Collaborator

echoix commented Oct 14, 2023

But the Auto-update step in the following PR #3008, which also builds the image, finished building the docker image now, without problem

@nvuillam
Copy link
Member Author

nvuillam commented Oct 14, 2023

@echoix I suspect either GitHub to have reduced free space on runners, either one of our linter or dependency to take much more space that it should ^^

Anyway, should be solved by #3009 as it provides 30GB additional space earlier in the workflow :)

@echoix
Copy link
Collaborator

echoix commented Oct 14, 2023

Looking at https://github.com/actions/runner-images/blob/ubuntu22/20231001.1/images/linux/Ubuntu2204-Readme.md, there is an announcement for

actions/runner-images#8383

Starting October 9, taking 3-4 days.

We failed with image 20231001.1.0, that was two weeks ago. I don't understand how an existing image version can change later on without a new number/date.

We had some runs with that version of the image work less than 7 hours ago, and some others that failed.

Also look at super-linter/super-linter#4735, and I suspect they use less space than us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants