Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hadolint: support both Containerfile and Dockerfile #3217

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

sanmai-NL
Copy link
Contributor

Fixes #

Proposed Changes

A vendor-neutral name for Dockerfile is Containerfile.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Member

@sanmai-NL thanks for the PR :)

Just add "Containerfile" in .cspell.json and it will pass :)

@sanmai-NL
Copy link
Contributor Author

@nvuillam Done. Can you finish the rest?

@nvuillam
Copy link
Member

@sanmai-NL i think once the CI passes we are all good, just remove the "draft" status of the PR if you consider it ready for merge :)

@sanmai-NL
Copy link
Contributor Author

@nvuillam Done.

@echoix
Copy link
Collaborator

echoix commented Dec 22, 2023

Thanks! The failure is unrelated and I don't understand the cause yet, but your job is done :)

@nvuillam nvuillam merged commit fa39f41 into oxsecurity:main Dec 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants