Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust find commands to clean up files in same step #3588

Merged
merged 5 commits into from
May 27, 2024
Merged

Adjust find commands to clean up files in same step #3588

merged 5 commits into from
May 27, 2024

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented May 27, 2024 •
edited
Loading

Adjust find commands to run on venv folder (for pip).
Adjust the final cleaning of python files after the megalinter install.

Use a single find command to clean npm files too.

Applied the corrections in the server folder too

Proposed Changes

  1. …
  2. …
  3. …

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix added the docker Pull requests that update Docker code label May 27, 2024
nvuillam
nvuillam approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nvuillam nvuillam merged commit c64e185 into oxsecurity:main May 27, 2024
6 checks passed
@echoix echoix deleted the find-cd-failing branch May 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees
No one assigned
Labels
docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echoix @nvuillam