Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

issue#34 #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issue#34 #36

wants to merge 1 commit into from

Conversation

hlYassine
Copy link

return simply the subprocess return value

@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage remained the same at 69.707% when pulling 22033a7 on hlYassine:master into 375261b on p-e-w:master.

Copy link

@BigAlInTheHouse BigAlInTheHouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extend your reading if you wish updated reviews.

@p-e-w
Copy link
Owner

p-e-w commented Dec 11, 2016

In principle, that's exactly what we want. Unfortunately, it doesn't actually work (see #34).

I believe the culprit is the wrapper created by pip install. No matter what value is returned by main, it doesn't reach the shell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants