Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 compatibility improvements + some useful algorithms #15

Merged
merged 5 commits into from
Mar 24, 2021
Merged

py3 compatibility improvements + some useful algorithms #15

merged 5 commits into from
Mar 24, 2021

Conversation

Pharisaeus
Copy link
Contributor

@Pharisaeus Pharisaeus commented Mar 23, 2021 •
edited
Loading

This pull request :

  • fixes empty result instead of \0 in long_to_bytes
  • fixes netcat_commons.py py3 compatibility
  • fixes off-byte one in repeating-xor automatic solver
  • adds bs-gs discrete log algorithm (was useful in some recent CTFs)
  • adds jacobi symbol (again useful in some recent CTFs)

@nazywam nazywam self-assigned this Mar 23, 2021
nazywam
nazywam approved these changes Mar 24, 2021
View reviewed changes
crypto_commons/generic.py Outdated Show resolved Hide resolved
crypto_commons/netcat/netcat_commons.py Outdated Show resolved Hide resolved
crypto_commons/netcat/netcat_commons.py Outdated Show resolved Hide resolved
crypto_commons/xor/repeating_xor.py Outdated Show resolved Hide resolved
crypto_commons/generic.py Outdated Show resolved Hide resolved
@Pharisaeus @nazywam
Apply suggestions from code review
4f04283 
Co-authored-by: Michał Praszmo <nazywam@gmail.com>
@nazywam
Copy link
Member

nazywam commented Mar 24, 2021

Thanks!

@nazywam nazywam merged commit cdbf342 into p4-team:master Mar 24, 2021
@Pharisaeus Pharisaeus deleted the improvements branch March 24, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazywam nazywam nazywam approved these changes

Assignees

@nazywam nazywam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pharisaeus @nazywam