Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert using Abseil system includes. #4594

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Revert using Abseil system includes. #4594

merged 2 commits into from
Apr 2, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Apr 2, 2024 •
edited
Loading

Reverts #4511 because of a diamond dependency problem.

@smolkaj I trade this for lobbying here :). Google projects have a habit of ignoring complaints by non-internal users.

@fruffy fruffy requested a review from smolkaj April 2, 2024 19:14
@smolkaj
Copy link
Member

smolkaj commented Apr 2, 2024

Thanks! Will take care of the lobbying :)

@smolkaj
Copy link
Member

smolkaj commented Apr 2, 2024

The bazel CI is failing:

./lib/bitrange.h:20:10: fatal error: absl/numeric/bits.h: No such file or directory
   20 | #include <absl/numeric/bits.h>

@fruffy fruffy enabled auto-merge April 2, 2024 20:48
@fruffy fruffy added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit a0520c8 Apr 2, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/revert_abseil_system_includes branch April 2, 2024 22:54
fruffy added a commit that referenced this pull request Apr 27, 2024
@fruffy
Revert "Revert using Abseil system includes. (#4594)"
4f4e69f 
This reverts commit a0520c8.
fruffy added a commit that referenced this pull request Apr 29, 2024
@fruffy
Revert "Revert using Abseil system includes. (#4594)"
bb95bee 
This reverts commit a0520c8.
fruffy added a commit that referenced this pull request Jun 12, 2024
@fruffy
Revert "Revert using Abseil system includes. (#4594)"
ff7fb61 
This reverts commit a0520c8.
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smolkaj smolkaj smolkaj approved these changes

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @smolkaj