Skip to content

Commit

Permalink
docs(ib): add note to the handler about Copr (#2561)
Browse files Browse the repository at this point in the history
docs(ib): add note to the handler about Copr

As we discussed with @majamassarini, we cannot find any use cases for supporting the VM image builds via Packit Service without any Copr repository set. Therefore adding a note about the fact that it's not possible as opposed to CLI support of this through ‹packit build in-image-builder›.
Related to packit/packit#1966, packit/packit#2434

Reviewed-by: Laura Barcziová
Reviewed-by: Maja Massarini
  • Loading branch information
2 parents 3f4ef01 + 2a8487e commit 87daf58
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packit_service/worker/handlers/vm_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ class VMImageBuildHandler(
def get_checkers() -> Tuple[Type[Checker], ...]:
return (
HasAuthorWriteAccess,
# [NOTE] We require Copr repository being present for the VM image
# builds via Packit Service as there are no common use cases that
# would benefit from relaxing this condition.
IsCoprBuildForChrootOk,
)

Expand Down

0 comments on commit 87daf58

Please sign in to comment.