Skip to content

Commit

Permalink
Update Bodhi updates task accepted message (#2315)
Browse files Browse the repository at this point in the history
Update Bodhi updates task accepted message

They are now visible in the dashboard.
See packit/dashboard#370

RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Nikola Forró
  • Loading branch information
softwarefactory-project-zuul[bot] authored Jan 25, 2024
2 parents 0bbfd66 + e31bfe9 commit baf8e29
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
10 changes: 4 additions & 6 deletions packit_service/worker/handlers/bodhi.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,11 @@ def get_handler_specific_task_accepted_message(
user = (
"packit" if service_config.deployment == Deployment.prod else "packit-stg"
)

return (
f"You can check the recent Bodhi update activity of `{user}` in "
f"[the Bodhi interface](https://bodhi.fedoraproject.org/users/{user}) (we "
f"have also planned adding support for viewing the updates"
f" in [Packit dashboard]({service_config.dashboard_url}), "
f"see [this issue](https://github.com/packit/dashboard/issues/187))."
"You can check the recent Bodhi update submissions of Packit "
f"in [Packit dashboard]({service_config.dashboard_url}/jobs/bodhi-updates). "
f"You can also check the recent Bodhi update activity of `{user}` in "
f"[the Bodhi interface](https://bodhi.fedoraproject.org/users/{user})."
f"\n\n---\n\n{CHANGED_LOADING_BEHAVIOUR_IN_DISTGIT_MESSAGE}"
)

Expand Down
9 changes: 5 additions & 4 deletions tests/integration/test_pr_comment.py
Original file line number Diff line number Diff line change
Expand Up @@ -2539,14 +2539,15 @@ def test_bodhi_update_retrigger_via_dist_git_pr_comment(pagure_pr_comment_added)
flexmock(target_branch="the_distgit_branch")
.should_receive("comment")
.with_args(
"The task was accepted. You can check the recent Bodhi update activity of `packit` in "
"[the Bodhi interface](https://bodhi.fedoraproject.org/users/packit) "
"(we have also planned adding support for viewing the updates in [Packit dashboard](), "
"see [this issue](https://github.com/packit/dashboard/issues/187))."
"The task was accepted. You can check the recent Bodhi update submissions of Packit "
"in [Packit dashboard](/jobs/bodhi-updates). "
"You can also check the recent Bodhi update activity of `packit` in "
"[the Bodhi interface](https://bodhi.fedoraproject.org/users/packit)."
f"\n\n---\n\n{CHANGED_LOADING_BEHAVIOUR_IN_DISTGIT_MESSAGE}"
)
.mock()
)

pagure_project = flexmock(
PagureProject,
full_repo_name="rpms/jouduv-dort",
Expand Down

0 comments on commit baf8e29

Please sign in to comment.