Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load downstream configuration from main #2272

Closed
3 of 7 tasks
lachmanfrantisek opened this issue Dec 7, 2023 · 0 comments · Fixed by #2295
Closed
3 of 7 tasks

Load downstream configuration from main #2272

lachmanfrantisek opened this issue Dec 7, 2023 · 0 comments · Fixed by #2295
Assignees
@lbarcziova
Labels
area/config Related to the Packit's configuration. area/fedora Related to Fedora ecosystem area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Dec 7, 2023 •
edited by lbarcziova
Loading

As a result of user feedback and team discussion, we would like to ease the downstream configuration and load it always from main distgit branch.

  • Change the implementation.
  • Make sure the --with-pr-config still works.
  • Properly communicate the change since it's backwards incompatible.
  • Make it clear in docs and Fedora onboarding guide
  • Add warning as a
    • PR description footer
    • retriggering comments
@lachmanfrantisek lachmanfrantisek added kind/feature New feature or a request for enhancement. area/user-experience Usability issue area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. area/config Related to the Packit's configuration. labels Dec 7, 2023
@lbarcziova lbarcziova self-assigned this Jan 5, 2024
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jan 5, 2024
@lbarcziova
Load package config from default branch for downstream jobs
af555b9 
With exception of using `/packit pull-from-upstream --with-pr-config`.
Fixes packit#2272
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Jan 5, 2024
@lbarcziova
Load package config from default branch for downstream jobs
fcbe324 
With exception of using `/packit pull-from-upstream --with-pr-config`.
Fixes packit#2272
@lbarcziova lbarcziova mentioned this issue Jan 5, 2024
Merged
1 task
softwarefactory-project-zuul bot added a commit that referenced this issue Jan 5, 2024
@softwarefactory-project-zuul
Load Packit config for koji-build and bodhi-update from the default d…
fc7bb65 
…ist-git branch (#2295)

Load Packit config for koji-build and bodhi-update from the default dist-git branch

TODO:

 update docs

Fixes #2272
Merge after packit/packit#2188

RELEASE NOTES BEGIN
TODO
RELEASE NOTES END

Reviewed-by: František Lachman <flachman@redhat.com>
lbarcziova added a commit to lbarcziova/packit.dev that referenced this issue Jan 8, 2024
@lbarcziova
Change docs for loading config for downstream jobs
8e9420d 
We have changed the behaviour of loading config for downstream jobs:
for all of them, the config in default dist-git branch is used.
Related to packit/packit-service#2272
@lbarcziova lbarcziova mentioned this issue Jan 8, 2024
Merged
lbarcziova added a commit to lbarcziova/packit.dev that referenced this issue Jan 9, 2024
@lbarcziova
Change docs for loading config for downstream jobs
7970694 
We have changed the behaviour of loading config for downstream jobs:
for all of them, the config in default dist-git branch is used.
Related to packit/packit-service#2272
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this issue Jan 9, 2024
@softwarefactory-project-zuul
Change docs for loading config for downstream jobs (#795)
b72740c 
Change docs for loading config for downstream jobs

We have changed the behaviour of loading config for downstream jobs: for all of them, the config in default dist-git branch is used. Related to packit/packit-service#2272

Reviewed-by: Maja Massarini
Reviewed-by: Nikola Forró
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/config Related to the Packit's configuration. area/fedora Related to Fedora ecosystem area/user-experience Usability issue complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/feature New feature or a request for enhancement.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
2 participants
@lachmanfrantisek @lbarcziova