GitHub: Consider only the events we are interested in #2066
Conversation
This extends the interested() method in the GitHub webhook, so that checks on the event type and action are done in the API. This will help avoid creating Celery tasks for these events. This change makes similar checks in Parser() redundant, but I've decided not to remove those, yet, mainly b/c it's hard to tell how that will influence parsing and telling which event is handled. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 11s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 09s |
|
We should find out if this really makes a difference by looking at this diagram on our metrics dashboard, after
Edit: the stage deployment does much less work (repos where it's installed are much less active), so it's hard to tell the exact impact of this change there. |
This extends the interested() method in the GitHub webhook, so that checks on the event type and action are done in the API. This will help avoid creating Celery tasks for these events.
This change makes similar checks in Parser() redundant, but I've decided not to remove those, yet, mainly b/c it's hard to tell how that will influence parsing and telling which event is handled.
TODO: