-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch errors when getting status of VM Image build #2418
Catch errors when getting status of VM Image build #2418
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: packit_service/worker/helpers/build/babysit.py
Did you find this useful? React with a 👍 or 👎 |
Build succeeded. ✔️ pre-commit SUCCESS in 5m 07s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 18s |
f"There was an exception when getting status of the VM " | ||
f"Image Build {build_id}: {ex}" | ||
) | ||
logger.error(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling this will still pop up in Sentry as it is an error 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it will, I thought it still may be beneficial to know about them 🤔 but I can change it to debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem if it's intentional :D
Fixes #2417
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END