Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors when getting status of VM Image build #2418

Merged

Conversation

lbarcziova
Copy link
Member

Fixes #2417

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

Copy link

sentry-io bot commented May 6, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packit_service/worker/helpers/build/babysit.py

Function Unhandled Issue
update_vm_image_build ImageBuilderError packit_service.worker.tasks.bab...
Event Count: 9

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label May 6, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3d8c109cf4834f6ea93ceb33a5d4f1b6

✔️ pre-commit SUCCESS in 2m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e2fbf60 into packit:main May 6, 2024
4 checks passed
@lbarcziova lbarcziova deleted the catch-ib-error branch May 6, 2024 10:22
f"There was an exception when getting status of the VM "
f"Image Build {build_id}: {ex}"
)
logger.error(message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this will still pop up in Sentry as it is an error 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it will, I thought it still may be beneficial to know about them 🤔 but I can change it to debug

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem if it's intentional :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle ImageBuilderError when babysitting VM image builds
4 participants