Improve error logging for Sentry errors reduction #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We capture the needed errors directly in the code, this just increases the number of errors sent to Sentry without adding too much value. Related to packit#2526
Do not log errors for failures/events that we cannot directly affect. Related to packit#2526
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 31s |
lbarcziova
changed the title
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 11s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
I wanted to remove the TaskResults completely, but in the end I think it can be useful for testing.
Related to #2526
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END