Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes related with packit service slowliness #2555

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Fixes related with packit service slowliness #2555

merged 4 commits into from
Oct 3, 2024

Conversation

majamassarini
Copy link
Member

Should partially fix #2512

@majamassarini majamassarini requested review from mfocko and a team as code owners October 1, 2024 13:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/443492b098944f44abb9270b0ace6449

✔️ pre-commit SUCCESS in 2m 21s
❌ packit-service-tests FAILURE in 2m 40s

lbarcziova
lbarcziova approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@majamassarini
Add timeout to requests
c976fd4 
Requests are blocking, a blocking call can be the cause of an hanging Celery task.
Hopefully it should fix point 4. of the following analysis
https://gist.github.com/majamassarini/85033b59607a3f3da570cf5aaf2b8c7a
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/eccd25b9ec91400e9f780dd9edb669b1

✔️ pre-commit SUCCESS in 2m 12s
❌ packit-service-tests FAILURE in 2m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/74fecacd3a3043a7a9725944fb9de96b

✔️ pre-commit SUCCESS in 2m 14s
❌ packit-service-tests FAILURE in 2m 37s

@majamassarini
Fix reporting of initial status check time
b601b34 
Now we report more than once a "first initial status check time".
The first is correct all the other are wrong.
Should fix point 7 in this analysis: https://gist.github.com/majamassarini/85033b59607a3f3da570cf5aaf2b8c7a
@majamassarini
Report uncatched Exception before cleaning the handler
de3f78c
@majamassarini
Add logs for debugging celery task hanging
e22ed44 
This should allow us to debug scenario 6. of the following analysis https://gist.github.com/majamassarini/85033b59607a3f3da570cf5aaf2b8c7a
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ee8b717e66014efcb47e1251f09f0f10

✔️ pre-commit SUCCESS in 2m 13s
✔️ packit-service-tests SUCCESS in 2m 32s

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Oct 3, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d483b62037b54aec9ffcfbf24dbea9b0

✔️ pre-commit SUCCESS in 2m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit be730d0 into packit:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfocko mfocko mfocko approved these changes

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard time limit (300s) exceeded for task.steve_jobs.process_message
3 participants
@majamassarini @mfocko @lbarcziova