Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename /packit propose-update to propose-downstream #913

Conversation

jpopelka
Copy link
Member

@jpopelka jpopelka commented Jan 4, 2021

Related to packit/packit#756

  • have /packit propose-update alias to /packit propose-downstream

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@jpopelka jpopelka marked this pull request as ready for review January 5, 2021 10:07
@jpopelka jpopelka added the ready-for-review Pull request is ready for review. label Jan 5, 2021
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one UX question

body_msg = (
f"Packit failed on creating pull-requests in dist-git:\n\n"
f"| dist-git branch | error |\n"
f"| --------------- | ----- |\n"
f"{branch_errors}\n\n"
f"{MSG_RETRIGGER.format(job='update', command='propose-update', place='issue')}\n"
f"{msg_retrigger}\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering if we want to place a comment here if a user writes propose-update instead of propose-downstream

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The message already says to use propose-downstream so the user should realize the change anyway. Thanks for review.

@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Jan 5, 2021
@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 89b05b8 into packit:master Jan 5, 2021
@jpopelka jpopelka deleted the propose-update2downstream branch January 5, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants