-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename /packit propose-update to propose-downstream #913
Rename /packit propose-update to propose-downstream #913
Conversation
This comment has been minimized.
This comment has been minimized.
d1df875
to
a5604a9
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one UX question
body_msg = ( | ||
f"Packit failed on creating pull-requests in dist-git:\n\n" | ||
f"| dist-git branch | error |\n" | ||
f"| --------------- | ----- |\n" | ||
f"{branch_errors}\n\n" | ||
f"{MSG_RETRIGGER.format(job='update', command='propose-update', place='issue')}\n" | ||
f"{msg_retrigger}\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering if we want to place a comment here if a user writes propose-update instead of propose-downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. The message already says to use propose-downstream
so the user should realize the change anyway. Thanks for review.
a5604a9
to
d97eab9
Compare
This comment has been minimized.
This comment has been minimized.
d97eab9
to
f62205d
Compare
Build succeeded.
|
Build succeeded (gate pipeline).
|
Related to packit/packit#756
/packit propose-update
alias to/packit propose-downstream