Feat: ARM64 Linux/MacOS Pact Ruby Standalone #445
Conversation
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Same review comments as on #444. I'm not sure what else is different on this one, but I'm happy to review it once #444 is merged. Also, same comment as before about the commit messages - ^ This will end up in the release notes, but that message isn't very suitable. It would mean that this needs to be squash merged with an appropriate message, but then you'd lose the nice individual commits you've got here. (you may be interested in release please, which lets you override the commit messages after a merge - although it also requires squash merges to do this) |
|
Additional changes in this introduce
CI runs to prove it all works, only thing worthy of note of reviewing is the standalone test, which probably warrants a refactor as the linux/macos tests were already in need of DRY, and adding the additional arches is just too many extra lines of code.
Yeah hmm, so the jist is, a linux user will require not entirely sure of the best way to communicate that to end users |
|
I'm quite happy just doing a soft reset on my commits and then just layering them with nice commit messages in steps, it's what I tend to do, after experimenting in ci, and having spurious commit messages with my handy |
|
Hey! It has been identified that there are a couple of issues noted in the new 2.x version of the pact-ruby-standalone, therefore I am switching this PR to a draft |
YOU54F
force-pushed
the
master-pf-2.0.0-standalone
branch
from
3ea1a32
to
aceee37
Compare
YOU54F
force-pushed
the
master-pf-2.0.0-standalone
branch
from
840c285
to
ea9f86f
Compare
…rade-to-pact-ruby-standalone-2-0-2 fix: update standalone to 2.0.2
|
I think the issues with the standalone are fixed now? |
…t/npm_and_yarn/json5-1.0.2 build(deps): bump json5 from 1.0.1 to 1.0.2
…-security-vulnerabilities chore: upgrade for security vulnerabilities
Yep, sorted in 2.0.2, will update the PR :) |
|
ohhhhh it was merged already |
…s-core into YOU54F-master-pf-2.0.0-standalone
Changes to traveling ruby to support additional platforms
Details of changes made to travelling ruby
PR's to Travelling ruby to update the supported archs
Which means we can now support
Details of changes made to pact-ruby-standalone
Details of changes made to pact-js
These have been consumed in the pact-js project, and tested cross platform
In order to test ARM64 on MacOS, and Linux, I have utilised cirrus-ci, which is free for open-source usage (within reasonable limits)
Related Issues
ia32for 32-bit windows, forpact-nodewhich is ruby backed. We don't currently ship 32 bit versions of pact_ffi, and I don't believe we've had a request yet (it is possible to build for them, but as to how far they will stretch, I am unsure)User facing notes
.cirrus.ymlfor an example of how one can install x64 versions withnvs, butpact-js-corewill determine this and use the appropriate FFI library, and now ruby standalone.