Fix/improve native logging lookup #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
reviewed
Jul 7, 2023
| if (opts.logLevel) { | ||
| setLogLevel(opts.logLevel); | ||
| } | ||
| const ffi = getFfiLib(opts.logLevel); |
mefellows
approved these changes
Jul 7, 2023
mefellows
reviewed
Jul 7, 2023
| } catch (error) { | ||
| renderBinaryErrorMessage(error, bindingPath); | ||
| // renderBinaryErrorMessage(error, bindingPath); |
There was a problem hiding this comment.
Will merge and then remove this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids the user having an error for the path lookups, when traversing each of the available binding paths, unless all paths are exhausted.
this way, if the library is available and working fine, users don't see an error in the logs.
if for whatever reason the library isn't loaded, an error message in displayed with some useful tips