feat: alpine support #507
feat: alpine support #507
Conversation
|
Amazing - will try and look today Yousaf! 👏 |
|
No rush at all dude! |
|
switching this to a draft, as there are a couple of additional things I want to do
but few changes I want to make in pact-ref with regards to some linker errors and content-type issues |
YOU54F
force-pushed
the
feat/alpine_support
branch
from
f4a9d28
to
c955716
Compare
|
|
||
| . "${SCRIPT_DIR}/lib/export-binary-versions.sh" | ||
| "${SCRIPT_DIR}/install-plugin-cli.sh" | ||
| $HOME/.pact/bin/pact-plugin-cli install -y https://github.com/mefellows/pact-matt-plugin/releases/tag/$PACT_PLUGIN_MATT_VERSION |
There was a problem hiding this comment.
should we add matt plugin the pact plugin index to save having to install it manually here and in the pact-go test suite?
.github/workflows/build-and-test.yml
Outdated
There was a problem hiding this comment.
builds and tests amd64/arm64 linux versions of glibc + musl variants of vanilla node images (-slim / -alpine respectively)
| "libraries": [ | ||
| "<(module_root_dir)/ffi/pact_ffi.dll.lib" | ||
| "variables": { | ||
| "is_alpine": "<!(grep -q Alpine /etc/os-release && echo true || echo false)" |
There was a problem hiding this comment.
This file is essentially the same despite the white space changes.
We check if the os is alpine and then build the musl bindings.
node-gyp-build detects musl at runtime when loading the libraries, so will correctly pick between musl/glibc as required
YOU54F
force-pushed
the
feat/alpine_support
branch
from
f84a370
to
a47fdb5
Compare
fixes #490
node.napi.musl.nodeforaarch64&x86_64musl variants