Merge pull request #14 from pagopa/io-core-ip-86-tslint2eslint

pagopa · Apr 15, 2021 · 45a490d · 45a490d
2 parents 6cf783c + 02689b3
commit 45a490d
Show file tree

Hide file tree

Showing 31 changed files with 1,347 additions and 389 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,24 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "ignorePatterns": [
+        "node_modules",
+        "generated",
+        "**/__tests__/*",
+        "**/__mocks__/*",
+        "Dangerfile.*",
+        "*.d.ts"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "extends": [
+        "@pagopa/eslint-config/strong",
+    ],
+    "rules": {}
+}
diff --git a/.gitignore b/.gitignore
@@ -50,8 +50,12 @@ generated
 *.zip
 
 *.js
+!.eslintrc.js
 !jest.config.js
 !.release-it.js
 
 
 azure-functions-core-tools
+
+# Exclude ESLint cache file
+.eslintcache
diff --git a/Dangerfile.ts b/Dangerfile.ts
@@ -1,7 +1,7 @@
 // import custom DangerJS rules
 // see http://danger.systems/js
 // see https://github.com/teamdigitale/danger-plugin-digitalcitizenship/
-// tslint:disable-next-line:prettier
+// eslint-disable-next-line prettier/prettier
 import checkDangers from "@pagopa/danger-custom-rules";
 
 checkDangers();
diff --git a/HandleNHCreateOrUpdateInstallationCallActivity/handler.ts b/HandleNHCreateOrUpdateInstallationCallActivity/handler.ts
@@ -32,6 +32,7 @@ export type ActivityBodyImpl = ActivityBody<
 
 export const getActivityBody = (
   buildNHService: (nhConfig: NotificationHubConfig) => NotificationHubService
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 ): ActivityBodyImpl => ({ input, logger }) => {
   logger.info(`INSTALLATION_ID=${input.installationId}`);
   const nhService = buildNHService(input.notificationHubConfig);

diff --git a/HandleNHCreateOrUpdateInstallationCallOrchestrator/handler.ts b/HandleNHCreateOrUpdateInstallationCallOrchestrator/handler.ts
@@ -21,15 +21,18 @@ export type NhCreateOrUpdateInstallationOrchestratorCallInput = t.TypeOf<
 >;
 
 interface IHandlerParams {
-  createOrUpdateActivity: o.CallableActivity<CreateOrUpdateActivityInput>;
-  notificationHubConfig: NotificationHubConfig;
+  readonly createOrUpdateActivity: o.CallableActivity<
+    CreateOrUpdateActivityInput
+  >;
+  readonly notificationHubConfig: NotificationHubConfig;
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export const getHandler = ({
   createOrUpdateActivity,
   notificationHubConfig
-}: IHandlerParams) => {
-  return o.createOrchestrator(
+}: IHandlerParams) =>
+  o.createOrchestrator(
     OrchestratorName,
     NhCreateOrUpdateInstallationOrchestratorCallInput,
     function*({
@@ -47,4 +50,3 @@ export const getHandler = ({
       });
     }
   );
-};
diff --git a/HandleNHCreateOrUpdateInstallationCallOrchestrator/index.ts b/HandleNHCreateOrUpdateInstallationCallOrchestrator/index.ts
@@ -2,14 +2,14 @@
 import * as o from "../utils/durable/orchestrators";
 
 import { getConfigOrThrow } from "../utils/config";
-import { getHandler } from "./handler";
 
 import {
   ActivityInput as CreateOrUpdateActivityInput,
   activityName as CreateOrUpdateActivityName,
   ActivityResultSuccess as CreateOrUpdateActivityResultSuccess
 } from "../HandleNHCreateOrUpdateInstallationCallActivity";
 import { getNHLegacyConfig } from "../utils/notificationhubServicePartition";
+import { getHandler } from "./handler";
 
 const config = getConfigOrThrow();
 

diff --git a/HandleNHDeleteInstallationCallActivity/handler.ts b/HandleNHDeleteInstallationCallActivity/handler.ts
@@ -31,6 +31,7 @@ export { ActivityResultSuccess } from "../utils/durable/activities";
 
 export const getActivityBody = (
   buildNHService: (nhConfig: NotificationHubConfig) => NotificationHubService
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 ): ActivityBody<ActivityInput, ActivityResultSuccess> => ({
   input,
   logger

diff --git a/HandleNHDeleteInstallationCallOrchestrator/handler.ts b/HandleNHDeleteInstallationCallOrchestrator/handler.ts
@@ -22,29 +22,25 @@ export const OrchestratorCallInput = t.interface({
 });
 
 interface IHandlerParams {
-  deleteInstallationActivity: o.CallableActivity<
+  readonly deleteInstallationActivity: o.CallableActivity<
     DeleteInstallationActivityInput
   >;
-  legacyNotificationHubConfig: NotificationHubConfig;
+  readonly legacyNotificationHubConfig: NotificationHubConfig;
 }
 
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export const getHandler = ({
   deleteInstallationActivity,
   legacyNotificationHubConfig
-}: IHandlerParams) => {
-  return o.createOrchestrator(
-    OrchestratorName,
-    OrchestratorCallInput,
-    function*({
-      context,
-      input: {
-        message: { installationId }
-      } /* , logger */
-    }): Generator<Task, void, Task> {
-      yield* deleteInstallationActivity(context, {
-        installationId,
-        notificationHubConfig: legacyNotificationHubConfig
-      });
-    }
-  );
-};
+}: IHandlerParams) =>
+  o.createOrchestrator(OrchestratorName, OrchestratorCallInput, function*({
+    context,
+    input: {
+      message: { installationId }
+    } /* , logger */
+  }): Generator<Task, void, Task> {
+    yield* deleteInstallationActivity(context, {
+      installationId,
+      notificationHubConfig: legacyNotificationHubConfig
+    });
+  });
diff --git a/HandleNHNotificationCall/__tests__/handler.test.ts b/HandleNHNotificationCall/__tests__/handler.test.ts
@@ -1,5 +1,4 @@
-// tslint:disable:no-any
-
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as df from "durable-functions";
 import { DurableOrchestrationClient } from "durable-functions/lib/src/durableorchestrationclient";
 import { NonEmptyString } from "italia-ts-commons/lib/strings";

diff --git a/HandleNHNotificationCallActivity/__tests__/handler.test.ts b/HandleNHNotificationCallActivity/__tests__/handler.test.ts
@@ -1,5 +1,4 @@
-/* tslint:disable: no-any */
-// tslint:disable-next-line: no-object-mutation
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { NonEmptyString } from "italia-ts-commons/lib/strings";
 import { context as contextMock } from "../../__mocks__/durable-functions";
 import { PlatformEnum } from "../../generated/backend/Platform";
@@ -94,7 +93,7 @@ describe("HandleNHNotificationCallActivity", () => {
     const handler = getCallNHServiceActivityHandler(mockTelemetryClient);
     const input = NHServiceActivityInput.encode({
       message: aDeleteInStalltionMessage,
-      notificationHubConfig: aNHConfig
+      NotificationHubConfig: aNHConfig
     });
     expect.assertions(2);
     await handler(contextMock as any, input);
@@ -106,7 +105,7 @@ describe("HandleNHNotificationCallActivity", () => {
     const handler = getCallNHServiceActivityHandler(mockTelemetryClient);
     const input = NHServiceActivityInput.encode({
       message: aCreateOrUpdateInstallationMessage,
-      notificationHubConfig: aNHConfig
+      NotificationHubConfig: aNHConfig
     });
 
     expect.assertions(2);
@@ -122,7 +121,7 @@ describe("HandleNHNotificationCallActivity", () => {
     const handler = getCallNHServiceActivityHandler(mockTelemetryClient);
     const input = NHServiceActivityInput.encode({
       message: aNotifyMessage,
-      notificationHubConfig: aNHConfig
+      NotificationHubConfig: aNHConfig
     });
     expect.assertions(2);
     try {
@@ -136,7 +135,7 @@ describe("HandleNHNotificationCallActivity", () => {
   it("should NOT trigger a retry if deleteInstallation fails", async () => {
     const handler = getCallNHServiceActivityHandler(mockTelemetryClient);
     const input = NHServiceActivityInput.encode({
-      notificationHubConfig: aNHConfig,
+      NotificationHubConfig: aNHConfig,
       message: aDeleteInStalltionMessage
     });
     const res = await handler(contextMock as any, input);

diff --git a/HandleNHNotificationCallActivity/handler.ts b/HandleNHNotificationCallActivity/handler.ts
@@ -2,7 +2,7 @@ import * as t from "io-ts";
 
 import { Context } from "@azure/functions";
 import { identity, toString } from "fp-ts/lib/function";
-import { fromEither, taskEither } from "fp-ts/lib/TaskEither";
+import { fromEither, taskEither, TaskEither } from "fp-ts/lib/TaskEither";
 
 import { readableReport } from "italia-ts-commons/lib/reporters";
 
@@ -34,7 +34,8 @@ import {
 // Activity input
 export const HandleNHNotificationCallActivityInput = t.interface({
   message: NotificationMessage,
-  notificationHubConfig: NotificationHubConfig
+  // eslint-disable-next-line sort-keys
+  NotificationHubConfig
 });
 
 export type HandleNHNotificationCallActivityInput = t.TypeOf<
@@ -48,6 +49,7 @@ export const getCallNHServiceActivityHandler = (
   // tslint:disable-next-line: no-unused-variable
   telemetryClient: ReturnType<typeof initTelemetryClient>,
   logPrefix = "NHCallServiceActivity"
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 ) => async (context: Context, input: unknown) => {
   const logger = createLogger(context, logPrefix);
   return fromEither(HandleNHNotificationCallActivityInput.decode(input))
@@ -57,51 +59,78 @@ export const getCallNHServiceActivityHandler = (
         readableReport(errs)
       )
     )
-    .chain<ActivityResultSuccess>(({ message, notificationHubConfig }) => {
-      context.log.info(
-        `${logPrefix}|${message.kind}|INSTALLATION_ID=${message.installationId}`
-      );
+    .chain<ActivityResultSuccess>(
+      ({
+        message,
+        // eslint-disable-next-line @typescript-eslint/no-shadow
+        NotificationHubConfig
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      }): TaskEither<any, ActivityResultSuccess> => {
+        context.log.info(
+          `${logPrefix}|${message.kind}|INSTALLATION_ID=${message.installationId}`
+        );
 
-      const nhService = buildNHService(notificationHubConfig);
+        const nhService = buildNHService(NotificationHubConfig);
 
-      switch (message.kind) {
-        case CreateOrUpdateKind.CreateOrUpdateInstallation:
-          return createOrUpdateInstallation(
-            nhService,
-            message.installationId,
-            message.platform,
-            message.pushChannel,
-            message.tags
-          ).mapLeft(e =>
-            retryActivity(logger, `${logPrefix}|ERROR=${toString(e)}`)
-          );
-        case NotifyKind.Notify:
-          return notify(nhService, message.installationId, message.payload)
-            .mapLeft(e =>
+        // eslint-disable-next-line default-case
+        switch (message.kind) {
+          case CreateOrUpdateKind.CreateOrUpdateInstallation:
+            return createOrUpdateInstallation(
+              nhService,
+              message.installationId,
+              message.platform,
+              message.pushChannel,
+              message.tags
+            ).mapLeft(e =>
               retryActivity(logger, `${logPrefix}|ERROR=${toString(e)}`)
-            )
-            .chainFirst(
-              taskEither.of(
-                telemetryClient.trackEvent({
-                  name: "api.messages.notification.push.sent",
-                  properties: {
-                    isSuccess: "true",
-                    messageId: message.payload.message_id
-                  },
-                  tagOverrides: { samplingEnabled: "false" }
-                })
-              )
             );
-        case DeleteKind.DeleteInstallation:
-          return deleteInstallation(nhService, message.installationId).mapLeft(
-            e => {
+          case NotifyKind.Notify:
+            return notify(nhService, message.installationId, message.payload)
+              .mapLeft(e =>
+                retryActivity(logger, `${logPrefix}|ERROR=${toString(e)}`)
+              )
+              .chainFirst(
+                taskEither.of(
+                  telemetryClient.trackEvent({
+                    name: "api.messages.notification.push.sent",
+                    properties: {
+                      isSuccess: "true",
+                      messageId: message.payload.message_id
+                    },
+                    tagOverrides: { samplingEnabled: "false" }
+                  })
+                )
+              );
+          // eslint-disable-next-line sonarjs/no-duplicated-branches, no-duplicate-case
+          case NotifyKind.Notify:
+            return notify(nhService, message.installationId, message.payload)
+              .mapLeft(e =>
+                retryActivity(logger, `${logPrefix}|ERROR=${toString(e)}`)
+              )
+              .chainFirst(
+                taskEither.of(
+                  telemetryClient.trackEvent({
+                    name: "api.messages.notification.push.sent",
+                    properties: {
+                      isSuccess: "true",
+                      messageId: message.payload.message_id
+                    },
+                    tagOverrides: { samplingEnabled: "false" }
+                  })
+                )
+              );
+          case DeleteKind.DeleteInstallation:
+            return deleteInstallation(
+              nhService,
+              message.installationId
+            ).mapLeft(e => {
               // do not trigger a retry as delete may fail in case of 404
               context.log.error(`${logPrefix}|ERROR=${toString(e)}`);
               return failActivity(logger)(e.message);
-            }
-          );
+            });
+        }
       }
-    })
+    )
     .fold<ActivityResult>(identity, success)
     .run();
 };
diff --git a/HandleNHNotificationCallOrchestrator/__tests__/handler.test.ts b/HandleNHNotificationCallOrchestrator/__tests__/handler.test.ts
@@ -1,5 +1,4 @@
-/* tslint:disable:no-any */
-// tslint:disable-next-line: no-object-mutation
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { NonEmptyString } from "italia-ts-commons/lib/strings";
 import { context as contextMock } from "../../__mocks__/durable-functions";
 import { PlatformEnum } from "../../generated/backend/Platform";
@@ -55,7 +54,7 @@ describe("HandleNHNotificationCallOrchestrator", () => {
       retryOptions,
       HandleNHNotificationCallActivityInput.encode({
         message: aNotificationHubMessage,
-        notificationHubConfig: {
+        NotificationHubConfig: {
           AZURE_NH_ENDPOINT: envConfig.AZURE_NH_ENDPOINT,
           AZURE_NH_HUB_NAME: envConfig.AZURE_NH_HUB_NAME
         }

diff --git a/HandleNHNotificationCallOrchestrator/handler.ts b/HandleNHNotificationCallOrchestrator/handler.ts
@@ -51,7 +51,7 @@ export const getHandler = (envConfig: IConfig) =>
 
     const nhCallOrchestratorInput: HandleNHNotificationCallActivityInput = {
       ...errorOrNHCallOrchestratorInput.value,
-      notificationHubConfig: nhConfig
+      NotificationHubConfig: nhConfig
     };
 
     yield context.df.callActivityWithRetry(

diff --git a/HandleNHNotifyMessageCallActivity/handler.ts b/HandleNHNotifyMessageCallActivity/handler.ts
@@ -15,10 +15,6 @@ import { notify } from "../utils/notification";
 import { NotifyMessage } from "../generated/notifications/NotifyMessage";
 import { NotificationHubConfig } from "../utils/notificationhubServicePartition";
 
-// message: t.string,
-// message_id: t.string,
-// title: t.string
-
 // Activity input
 export const ActivityInput = t.interface({
   message: NotifyMessage,
@@ -37,6 +33,7 @@ export { ActivityResultSuccess } from "../utils/durable/activities";
 export const getActivityBody = (
   telemetryClient: TelemetryClient,
   buildNHService: (nhConfig: NotificationHubConfig) => NotificationHubService
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 ): ActivityBody<ActivityInput, ActivityResultSuccess> => ({
   input,
   logger