[#IP-86] tslint to eslint migration

.devops/code-review-pipelines.yml

@@ -80,5 +80,5 @@ stages:
           displayName: 'Unit tests exec'
 
         - bash: |
-            bash <(curl -s https://codecov.io/bash)
+            bash <(curl -s https://codecov.bash)
           displayName: 'Code coverage'

.eslintignore

@@ -0,0 +1,9 @@
+# Never lint node_modules
+node_modules
+
+# We shouldn't lint assets nor generated files
+generated
+
+**/__tests__/*
+**/__mocks__/*
+Dangerfile.*

.eslintrc.js

@@ -0,0 +1,37 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "ignorePatterns": [
+        "node_modules",
+        "generated",
+        "**/__tests__/*",
+        "**/__mocks__/*",
+        "Dangerfile.*",
+        "*.d.ts"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "extends": [
+        "@pagopa/eslint-config/strong",
+    ],
+    "rules": {
+        "prefer-arrow/prefer-arrow-functions": "off",
+        "@typescript-eslint/naming-convention": "off",
+        "@typescript-eslint/explicit-function-return-type": "off",
+        "no-invalid-this": "off",
+        "@typescript-eslint/no-unused-expressions": "off",
+        "@typescript-eslint/no-explicit-any":"off",
+        "id-blacklist":"off",
+        "@typescript-eslint/ban-types":"off",
+        "sort-keys":"off",
+        "no-underscore-dangle":"off",
+        "functional/prefer-readonly-type":"off",
+        "@typescript-eslint/dot-notation": "off"
+    }
+}

.gitignore

@@ -50,8 +50,12 @@ generated
 *.zip
 
 *.js
+!.eslintrc.js
 !jest.config.js
 !.release-it.js
 
 
 azure-functions-core-tools
+
+# Exclude ESLint cache file
+.eslintcache

Dangerfile.ts

@@ -1,7 +1,7 @@
 // import custom DangerJS rules
 // see http://danger.systems/js
 // see https://github.com/teamdigitale/danger-plugin-digitalcitizenship/
-// tslint:disable-next-line:prettier
+// eslint-disable-next-line 
 import checkDangers from "@pagopa/danger-custom-rules";
 
 checkDangers();

HandleNHNotificationCall/__tests__/index.test.ts

@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// eslint-disable @typescript-eslint/no-explicit-any
 
 import * as df from "durable-functions";
 import { DurableOrchestrationClient } from "durable-functions/lib/src/durableorchestrationclient";
@@ -92,7 +92,7 @@ describe("HandleNHNotificationCall", () => {
   //     kind: "WrongMessage" as any
   //   };
 
-  //   // tslint:disable-next-line: no-let
+  //   // eslint-disable-next-line 
   //   let hasError = false;
   //   try {
   //     await HandleNHNotificationCall(context as any, aWrongMessage);

HandleNHNotificationCallActivity/__tests__/handler.test.ts

@@ -1,5 +1,5 @@
-/* tslint:disable: no-any */
-// tslint:disable-next-line: no-object-mutation
+/* eslint-disable @typescript-eslint/no-explicit-any */
+// eslint-disable-next-line 
 import { NonEmptyString } from "italia-ts-commons/lib/strings";
 import { context as contextMock } from "../../__mocks__/durable-functions";
 import { PlatformEnum } from "../../generated/backend/Platform";

HandleNHNotificationCallOrchestrator/__tests__/handler.test.ts

@@ -1,5 +1,5 @@
-/* tslint:disable:no-any */
-// tslint:disable-next-line: no-object-mutation
+/* eslint-disable @typescript-eslint/no-explicit-any */
+// eslint-disable-next-line 
 import { NonEmptyString } from "italia-ts-commons/lib/strings";
 import { context as contextMock } from "../../__mocks__/durable-functions";
 import { PlatformEnum } from "../../generated/backend/Platform";

package.json

@@ -17,7 +17,8 @@
     "dev": "npm-run-all --parallel start watch",
     "test": "jest",
     "test:coverage": "jest --coverage",
-    "lint": "tslint -p .",
+    "lint": "eslint . -c .eslintrc.js --ext .ts,.tsx",
+    "lint-autofix": "eslint . -c .eslintrc.js --ext .ts,.tsx --fix",
     "generate": "npm-run-all generate:backend:*",
     "generate:backend:api-models": "shx rm -rf generated/backend && shx mkdir -p generated/backend && gen-api-models --strict 0 --api-spec https://raw.githubusercontent.com/pagopa/io-backend/master/api_backend.yaml --out-dir generated/backend",
     "generate:backend:notification-models": "shx rm -rf generated/notifications && shx mkdir -p generated/notifications && gen-api-models --strict 0 --api-spec https://raw.githubusercontent.com/pagopa/io-backend/master/api_notifications.yaml --out-dir generated/notifications",
@@ -44,6 +45,7 @@
   },
   "devDependencies": {
     "@azure/functions": "^1.2.2",
+    "@pagopa/eslint-config": "^1.1.1",
     "@pagopa/danger-custom-rules": "^2.0.3",
     "@types/azure-sb": "^0.0.38",
     "@types/express": "^4.17.9",
@@ -54,7 +56,7 @@
     "danger": "^10.3.0",
     "dependency-check": "^4.1.0",
     "dotenv-cli": "^3.1.0",
-    "italia-tslint-rules": "*",
+    "eslint-plugin-prettier": "^3.3.1",
     "italia-utils": "^6.2.2",
     "jest": "^24.8.0",
     "jest-mock-express": "^0.1.1",
@@ -64,7 +66,6 @@
     "prettier": "^1.18.2",
     "shx": "^0.3.2",
     "ts-jest": "^24.0.2",
-    "tslint": "^5.17.0",
     "typescript": "^4.1.2"
   },
   "resolutions": {

utils/config.ts

@@ -15,11 +15,12 @@ export const IConfig = t.interface({
   AZURE_NH_ENDPOINT: NonEmptyString,
   AZURE_NH_HUB_NAME: NonEmptyString,
 
+  AzureWebJobsStorage: NonEmptyString,
+
   COSMOSDB_KEY: NonEmptyString,
   COSMOSDB_NAME: NonEmptyString,
   COSMOSDB_URI: NonEmptyString,
 
-  AzureWebJobsStorage: NonEmptyString,
   QueueStorageConnection: NonEmptyString,
 
   isProduction: t.boolean

utils/healthcheck.ts

@@ -135,7 +135,6 @@ export const checkApplicationHealth = (): HealthCheck<ProblemSource, true> =>
       // TODO: once we upgrade to fp-ts >= 1.19 we can use Validation to collect all errors, not just the first to happen
       sequenceT(taskEither)<
         ReadonlyArray<HealthProblem<ProblemSource>>,
-        // tslint:disable readonly-array beacuse the following is actually mutable
         Array<TaskEither<ReadonlyArray<HealthProblem<ProblemSource>>, true>>
       >(
         // checkAzureCosmosDbHealth(config.COSMOSDB_URI, config.COSMOSDB_KEY),

utils/notification.ts

@@ -51,22 +51,22 @@ class ExtendedNotificationHubService extends NotificationHubService {
   constructor(hubName: string, endpointOrConnectionString: string) {
     super(hubName, endpointOrConnectionString, "", "");
   }
-  // tslint:disable-next-line: typedef
+
   public _buildRequestOptions(
     webResource: unknown,
     body: unknown,
     options: unknown,
-    // tslint:disable-next-line: ban-types
+    // eslint-disable-next-line @typescript-eslint/ban-types
     cb: Function
   ) {
-    // tslint:disable-next-line: no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const patchedCallback = (err: any, cbOptions: any) => {
       cb(err, {
         ...cbOptions,
         agent: httpsAgent
       });
     };
-    // tslint:disable-next-line: no-string-literal  no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return super["_buildRequestOptions"](
       webResource,
       body,
@@ -146,6 +146,7 @@ const successNH = () =>
     kind: "SUCCESS"
   });
 
+/* eslint-disable arrow-body-style */
 export const notify = (
   installationId: NonEmptyString,
   payload: NotifyPayload