[IOPAY-402] update node 14 & fp-ts

.devops/code-review-pipelines.yml

@@ -7,7 +7,7 @@
 # 
 
 variables:
-  NODE_VERSION: '8.9.4'
+  NODE_VERSION: '14.16.0'
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
 
 # Automatically triggered on PR

.devops/deploy-pipelines.yml

@@ -18,7 +18,7 @@ parameters:
       - prod
 
 variables:
-  NODE_VERSION: '8.9.4'
+  NODE_VERSION: '14.16.0'
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
   ENV: ${{ parameters.ENV }}
 
@@ -154,7 +154,40 @@ stages:
               package: '$(Pipeline.Workspace)/Bundle'
               deploymentMethod: 'auto'
             displayName: Deploy to production slot
-
+
+  - stage: Api_test
+    dependsOn:
+      - Deploy_test
+    jobs:
+      - job: 'TestAPI'
+        steps:
+          - checkout: none
+
+          - download: current
+            artifact: Bundle
+
+      - job: waitStartup
+        steps:
+          - task: Delay@1
+            inputs:
+              delayForMinutes: '5'
+
+      - job: integrationTests
+        dependsOn: waitStartup
+        steps:
+          - script: |
+              yarn global add newman
+            displayName: 'newman installation'
+
+          - task: Bash@3
+            inputs:
+              targetType: filePath
+              filePath: k6example/ws.sh
+              arguments: postman
+              workingDirectory: k6example
+              failOnStdErr: true
+            displayName: Run API tests
+
   - stage: Deploy_production
     dependsOn:
       - Prepare_artifact

.eslintrc.js

@@ -0,0 +1,25 @@
+module.exports = {
+    "env": {
+        "es6": true,
+        "node": true
+    },
+    "ignorePatterns": [
+        "node_modules",
+        "generated",
+        "**/__tests__/*",
+        "**/__mocks__/*",
+        "*.d.ts",
+        "*.js",
+        "Dangerfile.ts",
+        "**/__integration__/*"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "./tsconfig.json",
+        "sourceType": "module"
+    },
+    "extends": [
+        "@pagopa/eslint-config/strong",
+    ],
+    "rules": {}
+  };

.gitignore

@@ -12,3 +12,4 @@ generated
 .env
 .DS_Store
 k6example/libs
+.eslintcache

.node-version

@@ -1 +1 @@
-8.9.4
+14.16.0

Dockerfile

@@ -1,6 +1,6 @@
-FROM circleci/node:8.9.4 as builder
+FROM circleci/node:14.16.0 as builder
 
-RUN sudo apt-get -y install --no-install-recommends libunwind8=1.1-3.2
+RUN sudo apt-get -y install --no-install-recommends libunwind8=1.1-4.1
 
 WORKDIR /usr/src/app
 
@@ -10,12 +10,13 @@ COPY /package.json /usr/src/app/package.json
 COPY /tsconfig.json /usr/src/app/tsconfig.json
 COPY /yarn.lock /usr/src/app/yarn.lock
 COPY /api_pagopa.yaml /usr/src/app/api_pagopa.yaml
+COPY /.eslintrc.js /usr/src/app/.eslintrc.js
 
 RUN sudo chmod -R 777 /usr/src/app \
   && yarn install \
   && yarn build
 
-FROM node:8.9.4-alpine
+FROM node:14.16.0-alpine
 LABEL maintainer="https://teamdigitale.governo.it"
 
 # Install major CA certificates to cover

package.json

@@ -22,24 +22,25 @@
     "generate:ts-from-yaml:nodeNm3psp": "shx mkdir -p generated/nodeNm3psp && rimraf generated/nodeNm3psp/* && gen-api-models --strict 0 --api-spec generated/yaml-file/nodeForPsp_Service.yaml --out-dir generated/nodeNm3psp",
     "generate:ts-from-yaml:nodeNm3io": "shx mkdir -p generated/nodeNm3io && rimraf generated/nodeNm3io/* && gen-api-models --strict 0 --api-spec generated/yaml-file/nodeForIO_Service.yaml --out-dir generated/nodeNm3io",
     "generate:yaml-from-wsdl": "shx mkdir -p generated/yaml-file && rimraf generated/yaml-file/* && node pagopa_api/YamlGenerator.js",
-    "generate:proxy-api-models": "shx mkdir -p generated/api && rimraf generated/api/* && gen-api-models --api-spec ./api_pagopa.yaml --out-dir generated/api --ts-spec-file generated/api/public_api_pagopa.ts --request-types",
+    "generate:proxy-api-models": "shx mkdir -p generated/api && rimraf generated/api/* && gen-api-models --api-spec ./api_pagopa.yaml --out-dir generated/api --request-types",
     "prettify": "prettier --write \"./**/*.ts\"",
     "start": "node dist/src/index.js",
-    "test:coverage": "jest --runInBand --coverage",
-    "test:integration": "jest --config=jest.integration.js --runInBand",
+    "test:coverage": "jest --runInBand --coverage --detectOpenHandles",
+    "test:integration": "jest --config=jest.integration.js --runInBand --detectOpenHandles",
     "test": "npm-run-all -s test:*",
-    "lint": "tslint --project .",
+    "lint": "eslint . -c .eslintrc.js --ext .ts,.tsx --cache",
     "postversion": "git push && git push --tags",
     "dist:modules": "modclean -r -n default:safe",
     "predeploy": "npm-run-all build dist:modules",
     "preversion": "auto-changelog  --config .auto-changelog.json --unreleased --commit-limit false --stdout --template preview.hbs",
     "version": "auto-changelog -p --config .auto-changelog.json --unreleased && git add CHANGELOG.md"
   },
   "devDependencies": {
+    "@pagopa/eslint-config": "^1.3.1",
     "@types/bluebird": "^3.5.24",
     "@types/debug": "0.0.30",
     "@types/express": "^4.11.1",
-    "@types/jest": "^23.3.2",
+    "@types/jest": "^27.0.3",
     "@types/morgan": "^1.7.35",
     "@types/node": "^8.9.4",
     "@types/node-fetch": "^2.1.1",
@@ -51,27 +52,26 @@
     "auto-changelog": "^2.2.1",
     "danger": "^7.1.4",
     "danger-plugin-digitalcitizenship": "^0.3.1",
-    "italia-tslint-rules": "^1.1.3",
-    "italia-utils": "^4.0.1",
-    "jest": "^23.6.0",
+    "eslint-plugin-prettier": "^4.0.0",
+    "jest": "^27.4.5",
     "jest-xml-matcher": "^1.1.1",
     "js-yaml": "^3.13.1",
     "modclean": "^3.0.0-beta.1",
     "npm-run-all": "^4.1.3",
     "prettier": "^1.14.3",
     "rimraf": "^2.6.3",
-    "shx": "^0.3.2",
+    "shx": "^0.3.3",
     "supertest": "^3.3.0",
-    "ts-jest": "^23.10.4",
-    "tslint": "^5.10.0",
-    "typescript": "^3.4.5"
+    "ts-jest": "^27.1.2",
+    "typescript": "^4.3.5"
   },
   "dependencies": {
+    "@pagopa/openapi-codegen-ts": "^10.0.6",
+    "@pagopa/ts-commons": "^10.2.0",
     "express": "^4.17.1",
     "fast-memoize": "^2.5.1",
-    "io-ts": "1.8.5",
-    "italia-pagopa-commons": "^1.0.0",
-    "italia-ts-commons": "^8.6.0",
+    "io-ts": "^2.2.16",
+    "fp-ts": "^2.11.1",
     "morgan": "^1.9.1",
     "node-forge": "^0.9.1",
     "redis": "^2.8.0",

src/App.ts

@@ -1,22 +1,22 @@
+/* eslint-disable prefer-arrow/prefer-arrow-functions */
 /**
  * App
  * Define a Restful and a SOAP Webservice and routes incoming requests to controllers
  */
 
+import * as http from "http";
 import * as appInsights from "applicationinsights";
 import * as bodyParser from "body-parser";
 import * as express from "express";
 import * as core from "express-serve-static-core";
-import * as http from "http";
-import { toExpressHandler } from "italia-ts-commons/lib/express";
+import { toExpressHandler } from "@pagopa/ts-commons/lib/express";
 import * as morgan from "morgan";
 import * as redis from "redis";
 import RedisClustr = require("redis-clustr");
 import * as soap from "soap";
 
-import { specs as publicApiV1Specs } from "../generated/api/public_api_pagopa";
+// import { specs as publicApiV1Specs } from "../generated/api/public_api_pagopa";
 import { Configuration } from "./Configuration";
-import { GetOpenapi } from "./controllers/openapi";
 import * as PaymentController from "./controllers/restful/PaymentController";
 import { requireClientCertificateFingerprint } from "./middlewares/requireClientCertificateFingerprint";
 import * as FespCdServer from "./services/pagopa_api/FespCdServer";
@@ -33,6 +33,7 @@ import { logger } from "./utils/Logger";
 /**
  * Define a Service Handler for FespCdService SOAP service
  * It's an endpoint for PagoPA to confirm a payment activation result
+ *
  * @param {redis.RedisClient} redisClient - Redis Client to store persistente paymentId into DB
  * @param {number} redisTimeoutSecs - Timeout set for information stored into DB
  * @return {IFespCdPortTypeSoap} An object containing the service handler
@@ -41,18 +42,15 @@ const getFespCdServiceHandler = (
   redisClient: redis.RedisClient,
   redisTimeoutSecs: number
 ): soap.IServicePort => ({
+  // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
   cdInfoWisp: (input, cb) => {
     logger.info(
-      `idpayment=${input.idPagamento}|contesto=${
-        input.codiceContestoPagamento
-      }|dominio=${input.identificativoDominio}|versamento=${
-        input.identificativoUnivocoVersamento
-      }`
+      `idpayment=${input.idPagamento}|contesto=${input.codiceContestoPagamento}|dominio=${input.identificativoDominio}|versamento=${input.identificativoUnivocoVersamento}`
     );
     const aiEventProps = {
-      idpayment: input.idPagamento,
       ccp: input.codiceContestoPagamento,
       iddominio: input.identificativoDominio,
+      idpayment: input.idPagamento,
       iuv: input.identificativoUnivocoVersamento
     };
     PaymentController.setActivationStatus(
@@ -68,7 +66,7 @@ const getFespCdServiceHandler = (
         if (cb) {
           // we need to cast the callback to any as the type definition doesn't
           // include all the actual parameters
-          // tslint:disable-next-line: no-any no-useless-cast
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           (cb as any)(undefined, iCdInfoWispOutput);
         }
       },
@@ -81,7 +79,7 @@ const getFespCdServiceHandler = (
         if (cb) {
           // we need to cast the callback to any as the type definition doesn't
           // include all the actual parameters
-          // tslint:disable-next-line: no-any no-useless-cast
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           (cb as any)(undefined, { esito: "KO" });
         }
       }
@@ -92,6 +90,7 @@ const getFespCdServiceHandler = (
 /**
  * Define and start an express Server
  * to expose RESTful and SOAP endpoints for BackendApp and Proxy requests.
+ *
  * @param {Configuration} config - The server configuration to use
  * @return {Promise<http.Server>} The express server defined and started
  */
@@ -103,9 +102,7 @@ export async function startApp(config: Configuration): Promise<http.Server> {
   const pagoPAClient = new PPTPortClient.PagamentiTelematiciPspNodoAsyncClient(
     await PPTPortClient.createPagamentiTelematiciPspNodoClient(
       {
-        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${
-          config.PAGOPA.WS_SERVICES.PAGAMENTI
-        }`,
+        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${config.PAGOPA.WS_SERVICES.PAGAMENTI}`,
         wsdl_options: {
           timeout: config.PAGOPA.CLIENT_TIMEOUT_MSEC
         }
@@ -119,9 +116,7 @@ export async function startApp(config: Configuration): Promise<http.Server> {
   const pagoPANm3PspClient = new NodoNM3PortClient.PagamentiTelematiciPspNm3NodoAsyncClient(
     await NodoNM3PortClient.createNm3NodoPspClient(
       {
-        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${
-          config.PAGOPA.WS_SERVICES.PAGAMENTI
-        }`,
+        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${config.PAGOPA.WS_SERVICES.PAGAMENTI}`,
         wsdl_options: {
           timeout: config.PAGOPA.CLIENT_TIMEOUT_MSEC
         }
@@ -135,9 +130,7 @@ export async function startApp(config: Configuration): Promise<http.Server> {
   const pagoPANm3IoClient = new NodoNM3PortClient.PagamentiTelematiciPspNm3NodoAsyncClient(
     await NodoNM3PortClient.createNm3NodoIoClient(
       {
-        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${
-          config.PAGOPA.WS_SERVICES.PAGAMENTI
-        }`,
+        endpoint: `${config.PAGOPA.HOST}:${config.PAGOPA.PORT}${config.PAGOPA.WS_SERVICES.PAGAMENTI}`,
         wsdl_options: {
           timeout: config.PAGOPA.CLIENT_TIMEOUT_MSEC
         }
@@ -150,6 +143,7 @@ export async function startApp(config: Configuration): Promise<http.Server> {
 
   // Define a redis client necessary to handle persistent data
   // for async payment activation process
+  // eslint-disable-next-line @typescript-eslint/no-use-before-define
   const redisClient = getRedisClient(config);
 
   // Define RESTful endpoints
@@ -166,6 +160,7 @@ export async function startApp(config: Configuration): Promise<http.Server> {
     app.use(requireClientCertificateFingerprint(clientCertificateFingerprint));
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-use-before-define
   setRestfulRoutes(
     app,
     config,
@@ -202,11 +197,13 @@ export function stopServer(server: http.Server): void {
 
 /**
  * Set RESTful WS endpoints
+ *
  * @param {core.Express} app - Express server to set
  * @param {Configuration} config - PagoPa proxy configuration
  * @param {redis.RedisClient} redisClient - The redis client used to store information sent by PagoPA
  * @param {PagamentiTelematiciPspNodoAsyncClient} pagoPAClient - PagoPa SOAP client to call verificaRPT and attivaRPT services
  */
+// eslint-disable-next-line max-params
 function setRestfulRoutes(
   app: core.Express,
   config: Configuration,
@@ -256,7 +253,8 @@ function setRestfulRoutes(
   );
 
   // Endpoint for OpenAPI handler
-  app.get("/api/v1/swagger.json", GetOpenapi(publicApiV1Specs));
+  // eslint-disable-next-line extra-rules/no-commented-out-code
+  // app.get("/api/v1/swagger.json", GetOpenapi(publicApiV1Specs));
 
   // Liveness probe for Kubernetes.
   // @see
@@ -268,11 +266,12 @@ function setRestfulRoutes(
 
 /**
  * Define a redis client necessary to handle persistent data
+ *
  * @param {Configuration} config - Server Configuration
  * @return {(app: core.Express) => soap.Server} A method to execute for start server listening
  */
 function getRedisClient(config: Configuration): redis.RedisClient {
-  const redisClient = (() => {
+  const redisClient = ((): redis.RedisClient => {
     if (config.REDIS_DB.USE_CLUSTER) {
       logger.debug("Creating a REDIS client using cluster...");
       return new RedisClustr({