add sourceUrl field to all entries #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 16, 2018 16:13
fully qualified github link including hash and line number!
📸Preview: docs |
adidahiya
reviewed
Jan 17, 2018
src/client/typescript.ts
Outdated
| * Otherwise, it will reference the current commit hash. | ||
| * @see ITypescriptPluginOptions.gitBranch | ||
| */ | ||
| url?: string; |
There was a problem hiding this comment.
I'd prefer a more verbose name, sourceUrl
giladgray
changed the title
sourceUrl 📸Preview: docs |
add # source links to themePreview: docs |
adidahiya
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gitBranchoption in case hash is a problem (like for snapshot testing, where updating snapshots creates a new commit and therefore new hash when building on circle...)