Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Enable deprecation rule in one of the built-in configurations #3856

Closed
tkrotoff opened this issue Apr 26, 2018 · 3 comments
Closed

Enable deprecation rule in one of the built-in configurations #3856

tkrotoff opened this issue Apr 26, 2018 · 3 comments
Labels
Resolution: Aged Away Type: Enhancement

Comments

@tkrotoff
Copy link

Using TSLint 5.9.1, deprecation rule should be enabled with preset "tslint:recommended" ("deprecation": true) because that makes a lot of sense
@tkrotoff tkrotoff mentioned this issue Apr 26, 2018
Merged
tkrotoff added a commit to tkrotoff/react-form-with-constraints that referenced this issue Apr 26, 2018
@tkrotoff
Use tslint:recommended and enable deprecation
fd1bd48 
See Enable deprecation rule with "tslint:recommended" palantir/tslint#3856
tkrotoff added a commit to tkrotoff/react-form-with-constraints that referenced this issue Apr 26, 2018
@tkrotoff
Use tslint:recommended and enable deprecation
75be01e 
See Enable deprecation rule with "tslint:recommended" palantir/tslint#3856
@JoshuaKGoldberg
Copy link
Contributor

Removing the Type: Breaking Change label per #4811. Now accepting PRs!

@adidahiya
Copy link
Contributor

Currently, we don't enable any rules which use the type checker in tslint:recommended, and I think we should keep it that way (they require extra setup). We might consider a new rule set tslint:recommended-with-type-checker which enables the deprecation rule.

@adidahiya adidahiya changed the title Enable deprecation rule with "tslint:recommended" Enable deprecation rule in one of the built-in configurations Oct 5, 2019
@JoshuaKGoldberg
Copy link
Contributor

IMO it's a little too late to add another ruleset. Let's just close this per #4534 🤷‍♂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Aged Away Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@giladgray @tkrotoff @adidahiya @JoshuaKGoldberg