improvement: Add Drain() method to tcpjson.AsyncWriter #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabboud
reviewed
Apr 22, 2021
| for { | ||
| select { |
There was a problem hiding this comment.
I don't believe we need this select block as the one below also includes selecting on <-stop and no where do we actually close the buffer chan
There was a problem hiding this comment.
It's an edge case, but this is attempting to handle where, at the start of the iteration, stop has been closed but there are still items in the buffer. In that case, the second select with both cases will nondeterministically choose one. Without the explicit check at the top, we could run for an unbound time after Close has been called.
There was a problem hiding this comment.
Ok got it, that makes sense then. Do you mind adding a short comment above this select to mention that this is guarding that edge case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get used during a process's shutdown when it wants to ensure that all logs have been sent to the TCP receiver.
This change is