Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume and generate Conjure API from Bintray #25

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Consume and generate Conjure API from Bintray #25

merged 2 commits into from
Jan 15, 2019

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Jan 14, 2019 •
edited by bmoylan
Loading

This change is Reviewable

@nmiyake nmiyake requested a review from bmoylan January 14, 2019 22:05
@nmiyake
Copy link
Contributor Author

nmiyake commented Jan 14, 2019

DO NOT MERGE: looking for feedback on general change, but should not be merged until a non-RC 1.0 release has been published.

bmoylan
bmoylan approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@bmoylan bmoylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine pending release of 1.0

Reviewed 21 of 21 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@nmiyake
Copy link
Contributor Author

nmiyake commented Jan 15, 2019

Merging now that PR has been updated to use released 1.0.0.

@nmiyake nmiyake merged commit 5439158 into develop Jan 15, 2019
@nmiyake nmiyake deleted the usePublishedConjure branch January 15, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoylan bmoylan bmoylan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmiyake @bmoylan