Add wapp.RunWithRecoveryLogging which does not return errors

[bmoylan]

It turns out that most usages of wapp.RunWithFatalLogging look something like this:

go func() {
	_ = wapp.RunWithFatalLogging(ctx, func(ctx context.Context) error {
		doAThing(ctx)
		return nil
	})
}

this can be simplified to

go wapp.RunWithRecoveryLogging(ctx, func(ctx context.Context) {
	doAThing(ctx)
})

---

This change is 

[nmiyake]

Is the canonical usage to ignore the error returned over-all? If so, then I think the intent of the change is reasonable.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bmoylan)

---

wlog/wapp/fatal.go, line 30 at r1 (raw file):

// Useful as a "catch all" for applications so that they can log fatal events, perhaps before exiting.
func RunWithRecovery(ctx context.Context, runFn func(ctx context.Context)) {
	defer func() {

Is there a reason this can't just be:

_ = RunWithFatalLogging(ctx, runFn)

?

[bmoylan]

Yeah, most usages ignore the error and handle logging something themselves so they can provide more context than the default log message.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nmiyake)

---

wlog/wapp/fatal.go, line 30 at r1 (raw file):

Previously, nmiyake (Nick Miyake) wrote…

Is there a reason this can't just be:

_ = RunWithFatalLogging(ctx, runFn)

?

lol, great call. Done.

[nmiyake]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved