improvement: Add tags to span as SpanOptions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoorpal
changed the title
bmoylan
approved these changes
Feb 15, 2021
tabboud
reviewed
Feb 15, 2021
wtracing/span.go
Outdated
| @@ -74,6 +75,7 @@ type SpanOptionImpl struct { | |||
| RemoteEndpoint *Endpoint | |||
| ParentSpan *SpanContext | |||
| Kind Kind | |||
| Tags []Tag | |||
There was a problem hiding this comment.
Is there any reason this is a []Tag instead of the map[string]string defined on the model? Using a map here would prevent the construction in span.go and embeds the logic of "most recent will prevail" since you can just overwrite existing values if they exist.
There was a problem hiding this comment.
This could just as easily be a map here. I was trying to consider what would be most performant but I think using a map in the SpanOption is just as good.
There was a problem hiding this comment.
Updated to be a map from the start. Removed the new unnecessary tag.go file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
wtracing did not use zipkin span tags
After this PR
==COMMIT_MSG==
Enable span tags as SpanOptions
==COMMIT_MSG==
This change is