Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Optimize read_excel nrows #46894

Merged
merged 15 commits into from
Jun 5, 2022
Merged

PERF: Optimize read_excel nrows #46894

merged 15 commits into from
Jun 5, 2022

Commits on Apr 28, 2022

  1. Check for nrows in read_excel

    @ahawryluk
    ahawryluk committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6fd0422 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Add nrows tests for multiindex and skiprows

    @ahawryluk
    ahawryluk committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    e4d52d8 View commit details
    Browse the repository at this point in the history

  2. code linting and fix a bug in a test

    @ahawryluk
    ahawryluk committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    eb83a74 View commit details
    Browse the repository at this point in the history

  3. What's new entry

    @ahawryluk
    ahawryluk committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    2c643c7 View commit details
    Browse the repository at this point in the history

  4. Add asv test with nrows=10

    @ahawryluk
    ahawryluk committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    dc14ac2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Parametrize new tests

    @ahawryluk
    ahawryluk committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2e79141 View commit details
    Browse the repository at this point in the history

  2. Docstrings and type hints

    @ahawryluk
    ahawryluk committed May 6, 2022
    Configuration menu
    Copy the full SHA
    943f866 View commit details
    Browse the repository at this point in the history

  3. Add PR #

    @ahawryluk
    ahawryluk committed May 6, 2022
    Configuration menu
    Copy the full SHA
    10a8a3e View commit details
    Browse the repository at this point in the history

  4. Use is_integer and validate_integer

    @ahawryluk
    ahawryluk committed May 6, 2022
    Configuration menu
    Copy the full SHA
    30a280c View commit details
    Browse the repository at this point in the history

  5. Consolidate header arg validation

    @ahawryluk
    ahawryluk committed May 6, 2022
    Configuration menu
    Copy the full SHA
    bbc1f1d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. Attempting to placate mypy with assert statements

    @ahawryluk
    ahawryluk committed May 7, 2022
    Configuration menu
    Copy the full SHA
    2018d26 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. make type checks pass with typing.cast

    @ahawryluk
    ahawryluk committed May 10, 2022
    Configuration menu
    Copy the full SHA
    c108a97 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Do not allow sets for header arg 

    Sets for skiprows currently work, so I've left that as is.
    @ahawryluk
    ahawryluk committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3aad835 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Merge branch 'main' into opt_excel_nrows

    @ahawryluk
    ahawryluk committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7c913d6 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Two more allow_set=False

    @ahawryluk
    ahawryluk committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d6e1df3 View commit details
    Browse the repository at this point in the history