Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Use large_string in string array consistently #58590

Merged
merged 1 commit into from
May 6, 2024
Merged

BUG: Use large_string in string array consistently #58590

merged 1 commit into from
May 6, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented May 6, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This is not user visible, since the constructor casts back, but it's unnecessary

@phofl phofl added this to the 2.2.3 milestone May 6, 2024
@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels May 6, 2024
@mroeschke mroeschke merged commit 627eac8 into pandas-dev:main May 6, 2024
48 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request May 6, 2024
@phofl @meeseeksmachine
Backport PR pandas-dev#58590: BUG: Use large_string in string array c…
89dc08b 
…onsistently
@meeseeksmachine meeseeksmachine mentioned this pull request May 6, 2024
Merged
@phofl phofl deleted the string_copies branch May 6, 2024 17:36
mroeschke pushed a commit that referenced this pull request May 6, 2024
@meeseeksmachine @phofl
Backport PR #58590 on branch 2.2.x (BUG: Use large_string in string a…
ecb90b5 
…rray consistently) (#58597)

Backport PR #58590: BUG: Use large_string in string array consistently

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@phofl @pmhatre1
BUG: Use large_string in string array consistently (pandas-dev#58590)
850d3d4
@DeaMariaLeon DeaMariaLeon mentioned this pull request May 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke