Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section 'Adaptive Masking' to Masking.ipynb #187

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

sol1105
Copy link
Contributor

@sol1105 sol1105 commented Aug 8, 2022

This PR

  • adds a section to the documentation (in Masking.ipynb) explaining the adaptive masking technique (skipna and na_thres parameters of Regridder.__call__).
  • corrects a typo in the explanation of skipna in frontend.py.

In the regrid_nomask example in Masking.ipynb I changed the weights creation from "conservative_normed" to "conservative" so I can use this weights in the adaptive masking example. This should not affect the regrid_nomask example.

I'm happy for feedback regarding the wording :)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

doc/notebooks/Masking.ipynb Outdated Show resolved Hide resolved
@raphaeldussin raphaeldussin merged commit af2864d into pangeo-data:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants