Compatibility with Numpy 2.0 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huard
approved these changes
Jun 26, 2024
| @@ -202,11 +202,11 @@ def apply_weights(weights, indata, shape_in, shape_out): | |||
|
|
|||
|
|
|||
| def add_nans_to_weights(weights): | |||
| """Add NaN in empty rows of the regridding weights sparse matrix. | |||
There was a problem hiding this comment.
Did you intend to change the comments as well. I don't really case either way.
There was a problem hiding this comment.
At first I did and then I decided I did not care enough to change the comments in the other files.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370.
NaN -> nan