Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate releases with release.yaml #80

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Automate releases with release.yaml #80

merged 6 commits into from
Aug 29, 2023

Conversation

cisaacstern
Copy link
Member

@cisaacstern cisaacstern commented Aug 1, 2023

Currently:

  • latest release according to pypi is 0.7.1
  • latest tag on GitHub is v0.7.0
  • latest release according to GitHub releases page is 0.6.1

🙃

This PR adds the same release.yaml as used in pangeo-forge-recipes to automate this process.

@yuvipanda, if this looks good to you, I can add a pypi token as a repo secret and cut a 0.8.0 release.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #80 (1c8ba25) into main (5b2faba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          13       13           
  Lines         424      424           
=======================================
  Hits          406      406           
  Misses         18       18           

@yuvipanda
Copy link
Collaborator

@cisaacstern you can use pypi's trusted publisher instead, is easier! https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/

Feel free to self-merge once you set that up! Here's an example PR in another project: jupyterhub/jupyter-remote-desktop-proxy#46

@cisaacstern
Copy link
Member Author

cisaacstern commented Aug 25, 2023

@yuvipanda thanks, didn't know about trusted publishing, it's great! Added that.

Pinging you for a quick re-review because I also changed a few other things to enable dynamic versioning... look okay to you?

Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about when to trigger, but otherwise if this works go for it! Thanks for taking care of it, @cisaacstern!

.github/workflows/release.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for indulging me, @cisaacstern! Feel free to merge whenever you feel like

@cisaacstern cisaacstern merged commit b4e918a into main Aug 29, 2023
7 of 8 checks passed
@cisaacstern cisaacstern mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants