Skip to content
This repository has been archived by the owner on Jun 10, 2023. It is now read-only.

FIX - add alignment info to imgproc and figure shortcodes #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aormsby
Copy link
Contributor

@aormsby aormsby commented Sep 13, 2020

The imgproc and figure shortcodes have some alignment issues. The <img> element is always left-aligned within the figure element and can look strange when the caption is wider than the image. (Maybe related to recent figure styling updates?)

Screen Shot 2020-09-13 at 16 17 02

My current fix is to add the class position parameters to the internal img tags. The alignment of the image will match the alignment of the figure. I'm wondering if it's a little hacky, but it does work.

Screen Shot 2020-09-13 at 16 18 59

If this works for you, it should be ready to go.

@aormsby
Copy link
Contributor Author

aormsby commented Sep 13, 2020

In addition, I've added alt text and hyperlinks to my image options over here. I'm happy to include those enhancements in my PR if you're interested in having them. Just let me know. :)

@aormsby aormsby marked this pull request as ready for review September 13, 2020 21:22
@panr
Copy link
Owner

panr commented Nov 1, 2021

Sorry for a late response (I don't where I've been for the whole year...). I'd be nice if you still want to add alt and hiperlinks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants