Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pants to pex 1.4.x #5906

Closed
jsirois opened this issue Jun 4, 2018 · 4 comments · Fixed by #5910
Closed

Upgrade pants to pex 1.4.x #5906

jsirois opened this issue Jun 4, 2018 · 4 comments · Fixed by #5910
Assignees

Comments

@jsirois
Copy link
Contributor

jsirois commented Jun 4, 2018

This will pick up manylinux support and should enable us to discontinue publishing a pantsbuild.pants source tarball (which is invalid - it contains a ~random embedded native engine resource, ie: an OSX or a linux native engine, but not both).

@jsirois jsirois self-assigned this Jun 4, 2018
@jsirois
Copy link
Contributor Author

jsirois commented Jun 4, 2018

@kwlzn I broke out this pex upgrade step mainly for visibility. I don't want to step on toes. Ping me if I should desist in favor of work in progress I may not be aware of.

@jsirois
Copy link
Contributor Author

jsirois commented Jun 4, 2018

Ah, looks like @kwlzn has this over in #5875.

@jsirois jsirois assigned kwlzn and unassigned jsirois Jun 4, 2018
@jsirois jsirois assigned jsirois and unassigned kwlzn Jun 4, 2018
jsirois added a commit to jsirois/pants that referenced this issue Jun 4, 2018
This hacks around issues with pex resolve where an interprete is passed
in but no platforms are specified.

Fixes pantsbuild#5906
jsirois added a commit to jsirois/pants that referenced this issue Jun 5, 2018
This hacks around issues with pex resolve where an interprete is passed
in but no platforms are specified.

Fixes pantsbuild#5906
@jsirois
Copy link
Contributor Author

jsirois commented Jun 6, 2018

Noting that CI failures in #5910 are going to force fixing #4956 in the same change.

jsirois added a commit to jsirois/pants that referenced this issue Jun 6, 2018
This hacks around issues with pex resolve where an interprete is passed
in but no platforms are specified.

Fixes pantsbuild#5906
jsirois added a commit to jsirois/pants that referenced this issue Jun 6, 2018
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local `Platform` to pass to `resolve` where a local interpreter
is passed to work around pex-tool/pex#511.
We also now consolidate `PythonInterpreter` construction in production
code to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.

Upgrading pex to take advantage of the worked around issues noted above
is tracked by pantsbuild#5922.

Fixes pantsbuild#5906
jsirois added a commit to jsirois/pants that referenced this issue Jun 6, 2018
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local `Platform` to pass to `resolve` where a local interpreter
is passed to work around pex-tool/pex#511.
We also now consolidate `PythonInterpreter` construction in production
code to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.

Upgrading pex to take advantage of the worked around issues noted above
is tracked by pantsbuild#5922.

Fixes pantsbuild#5906
jsirois added a commit to jsirois/pants that referenced this issue Jun 6, 2018
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local `Platform` to pass to `resolve` where a local interpreter
is passed to work around pex-tool/pex#511.
We also now consolidate `PythonInterpreter` construction in production
code to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.

Upgrading pex to take advantage of the worked around issues noted above
is tracked by pantsbuild#5922.

Fixes pantsbuild#5906
@stuhood
Copy link
Sponsor Member

stuhood commented Jun 6, 2018

Thanks John!

jsirois added a commit to jsirois/pants that referenced this issue Jun 7, 2018
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local `Platform` to pass to `resolve` where a local interpreter
is passed to work around pex-tool/pex#511.
We also now consolidate `PythonInterpreter` construction in production
code to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.

Upgrading pex to take advantage of the worked around issues noted above
is tracked by pantsbuild#5922.

Fixes pantsbuild#5906
jsirois added a commit that referenced this issue Jun 7, 2018
This hacks around a few issues with the 1.4.x pex API. We concoct a
minimal local `Platform` to pass to `resolve` where a local interpreter
is passed to work around pex-tool/pex#511.
We also now consolidate `PythonInterpreter` construction in production
code to helper that ensures the interpreters we create are bare
(isolated) except for the specific extras we require to work around
pex-tool/pex#510.

Upgrading pex to take advantage of the worked around issues noted above
is tracked by #5922.

Fixes #5906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants