Port fs #6091
Merged
Port fs #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Jul 11, 2018
|
Google docs is telling me I need permission to view that spreadsheet -- unsure if the access is intentionally limited. imho one directory per PR is fantastic for the exact reasons you described, having a consistent metric makes it easier to not accidentally cut corners even if the diffs are tiny (imho). If there are reasons to make them larger, go ahead, but this is fine (imho). |
|
@cosmicexplorer My bad, try the link again. Great, I'm happy to keep doing one directory per PR! We found some directories don't even need changes also |
|
That link works now! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6062
P.S. Let me know if these PRs are too small - I've been keeping it one directory per PR so that we can use
git bisect/ debug easier and make it easier to do code review. This means we'll eventually have 54 PRs in total (spreadsheet tracking this all)