Use extended platform specification for current platform in resolve_multi.
#6099
Conversation
| @@ -32,3 +32,13 @@ def get_local_platform(): | |||
| # is fixed. | |||
| current_platform = Platform.current() | |||
| return current_platform.platform | |||
|
|
|||
|
|
|||
| def get_extended_local_platform(): | |||
There was a problem hiding this comment.
haven't profiled it, but I suspect not.
|
I don't think this is right either. The fundamental problem right now is, given an interpreter and no platform, the pex resolve method chooses Platform.current() instead of the platform of the given interpreter (which there is no sane public way to calculate with the pex API as is today - a wart from the initual manylinux PR). As an aside, pex understands 'current', so this PR could be replaced by just passing Either way, this should fail in CI unless I was hallucinating when I upgraded us to 1.4.4, which required the truncated platform workaround. |
|
Clearly? the truncation workaround is broken but it specifically targeted this logic: |
|
discussed in Slack, but will discard this in favor of John's current |
|
Resurrected this PR in simpler form in #6104. We'll see how CI goes. If ok - the rest of the pex work and re-consumption in Pants can happen without blocking broken builds over here in Pants land. |
Improves ABI selection for resolved dists to avoid cases like e.g.
where the platform=current ABI type is
cp27muvscp27m.