-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port option/ to python3 #6117
Port option/ to python3 #6117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@ghthor : Looks like there is a lint issue: recommend using |
@stuhood noted. I'll do that and update. |
Ok, fixed the linting issues. Looks like a test failure[1][2] due to underlying type changes used for comparisons. @Eric-Arellano Does this make sense within the context of what's happening? [1] https://travis-ci.org/pantsbuild/pants/jobs/404468884#L5273 |
@ghthor you can fix the test by adding The reason that test is failing is that |
2f9fe76
to
8aa09d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Followup for #6062. Almost all automated changes, the the exception of the change from using
map()
to a for loop.