Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 - fixes to get green contrib #6340

Merged
merged 21 commits into from
Aug 16, 2018
Merged

Python 3 - fixes to get green contrib #6340

merged 21 commits into from
Aug 16, 2018

Commits on Aug 12, 2018

  1. Fix issues with strutil. 

    * Shlex expects unicode in Py3
* Use builtins instead of binary_type and text_type
    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    f19f3a5 View commit details
    Browse the repository at this point in the history

  2. Fix issues with contrib go.

    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    022d6c2 View commit details
    Browse the repository at this point in the history

  3. Fix integration test logger issue

    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    aeb72be View commit details
    Browse the repository at this point in the history

  4. Fix integration test issue with binary stdin

    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    dfb5d0d View commit details
    Browse the repository at this point in the history

  5. Fix node issue so that its stdout returns unicode

    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    e6174d9 View commit details
    Browse the repository at this point in the history

  6. Fix Py3 issues with contrib scrooge. 

    * Make thrift_linter test's mock's arg order be deterministic
* Fix hasher unicode issue
    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    8bc11cf View commit details
    Browse the repository at this point in the history

  7. Fix BeautifulSoup warnings

    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    8c79503 View commit details
    Browse the repository at this point in the history

  8. Replace test_checker's example of print statements to bad class name. 

    Python 3 raises a syntax error upon print statements, so the tests don't work as expected. Instead, bad class variable names works consistently across both Py2 and Py3.
    Eric Arellano committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    8b78fbe View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. Partially fix contrib python_eval - unicode hasher issues

    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    2126adc View commit details
    Browse the repository at this point in the history

  2. Fix ivy resolver hash issues

    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    ec8f547 View commit details
    Browse the repository at this point in the history

  3. Add Python 3 contrib job to CI

    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    17137b2 View commit details
    Browse the repository at this point in the history

  4. Pass unicode to json.loads()

    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    6c16095 View commit details
    Browse the repository at this point in the history

  5. Remove decodes() now that node's command.py decodes

    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    fd184f2 View commit details
    Browse the repository at this point in the history

  6. Fix regex for non-deterministic ordering of go command's environment … 

    …variables
    Eric Arellano committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    7fd5da4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Fix ivy XML failing to read generated files due to b'' string prefix

    Eric Arellano committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    4194f10 View commit details
    Browse the repository at this point in the history

  2. Fix exceptions no longer having message attribute

    Eric Arellano committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    b89f16e View commit details
    Browse the repository at this point in the history

  3. Fix unicode vs bytes issues in nailgun_executor. 

    The original fixes I made over-used bytes and had issues with mixing bytes and strings.
    Eric Arellano committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    302a6df View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into py3-green_contrib

    Eric Arellano committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    c8bfdf2 View commit details
    Browse the repository at this point in the history

  5. Make bytes check more idiomatic from pantsbuild#6316

    Eric Arellano committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    2a64b85 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Skip Python Eval tests pantsbuild#6354

    Eric Arellano committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    503b0c6 View commit details
    Browse the repository at this point in the history

  2. DRY regex changes

    Eric Arellano committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    71dd278 View commit details
    Browse the repository at this point in the history