Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save entity specific connection string #560

Closed
avdv opened this issue Jun 10, 2021 · 5 comments · Fixed by #562
Closed

Cannot save entity specific connection string #560

avdv opened this issue Jun 10, 2021 · 5 comments · Fixed by #562
Milestone

Comments

@avdv
Copy link
Contributor

avdv commented Jun 10, 2021

My connection string includes an EntityPath=... stanza at the end.

Trying to save this string in the connection dialog displays an error message:
image

Removing the Entity Path setting and hitting "Save" stores the configuration.

But I cannot connect without the entity path being present, so every time I need to use File -> Connect.., enter the entity path and hit OK instead of just using the saved connection from File -> Saved Connection (ie. Ctrl+1).

@SeanFeldman
Copy link
Collaborator

Please see #375 (comment)

@avdv
Copy link
Contributor Author

avdv commented Jun 10, 2021

Please see #375 (comment)

What does it mean? I read this issue, saw the comment, but the issue was closed as fixed and "already working as expected"?

@avdv
Copy link
Contributor Author

avdv commented Jun 11, 2021

Wouldn't this just need the same change as in #422 ?

Ie. just remove this check:

if (serviceBusConnectionStringBuilder.EntityPath != null)
{
MainForm.StaticWriteToLog(ConnectionStringCannotBeEntitySpecific);
MessageBox.Show(
this,
$"{ConnectionStringCannotBeEntitySpecific}\n\n{ConnectionStringCannotBeEntitySpecificDetails}",
"Save connection string",
MessageBoxButtons.OK,
MessageBoxIcon.Exclamation);
return;
}

@ErikMogensen
Copy link
Collaborator

@avdv, can you try it? If it works, please create a PR for it.

@avdv
Copy link
Contributor Author

avdv commented Jun 11, 2021

@avdv, can you try it? If it works, please create a PR for it.

Already on it right now... Works like a charm. PR coming up next.

avdv added a commit to avdv/ServiceBusExplorer that referenced this issue Jun 11, 2021
In the same vain as paolosalvatori#422 this simply removes the check for entity specific connection strings since it is just working flawlessly.

Fixes paolosalvatori#560
avdv added a commit to avdv/ServiceBusExplorer that referenced this issue Jun 11, 2021
In the same vain as paolosalvatori#422 this simply removes the check for entity specific connection strings since it is just working flawlessly.

Fixes paolosalvatori#560
avdv added a commit to avdv/ServiceBusExplorer that referenced this issue Jun 11, 2021
In the same vein as paolosalvatori#422 this simply removes the check for entity specific connection strings since it is just working fine.

Fixes paolosalvatori#560
SeanFeldman pushed a commit that referenced this issue Jun 13, 2021
In the same vein as #422 this simply removes the check for entity specific connection strings since it is just working fine.

Fixes #560
@SeanFeldman SeanFeldman added this to the 5.0.4 milestone Jun 13, 2021
ErikPilsits-RJW pushed a commit to ErikPilsits-RJW/ServiceBusExplorer that referenced this issue Dec 16, 2021
In the same vein as paolosalvatori#422 this simply removes the check for entity specific connection strings since it is just working fine.

Fixes paolosalvatori#560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants