Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist Message Content Type in the settings #402

Merged

Conversation

Greybird
Copy link
Contributor

@Greybird Greybird commented Dec 28, 2019

This PR ensures that the Content Type configured for sending message is part of the options, and will be persisted.

The rationale behind this proposal is that it is very useful for people working with systems or libraries that require specific content type to allow retaining it across executions of the tool.

An example which is very frequent for my company is to set the @MassTransit application/vnd.masstransit+json content type when sending messages manually, so that the library can consume them. It would save a lot of time to be able to have the tool retain it!

Screenshots

The new Options UI:
image

The Send Message UI after doing this configuration:
image

@SeanFeldman
Copy link
Collaborator

bigmat
bigmat previously approved these changes Dec 29, 2019
Copy link

@bigmat bigmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍
Masstransit users will love that

SeanFeldman
SeanFeldman previously approved these changes Dec 29, 2019
@SeanFeldman
Copy link
Collaborator

Thank you, @Greybird.

Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you., @Greybird . When there are changes to the GUI we would like to see screenshots of the changed windows. Please provide screenshots of the modified dialog windows.

@Greybird
Copy link
Contributor Author

Greybird commented Dec 30, 2019

Thank you., @Greybird . When there are changes to the GUI we would like to see screenshots of the changed windows. Please provide screenshots of the modified dialog windows.

Hi!
Sure! I added them to the initial post.
Thanks

@Greybird Greybird dismissed stale reviews from SeanFeldman and bigmat via 1430e0d December 30, 2019 13:19
@SeanFeldman
Copy link
Collaborator

@SeanFeldman
Copy link
Collaborator

Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SeanFeldman SeanFeldman merged commit 4abcd21 into paolosalvatori:develop Dec 31, 2019
@Greybird Greybird deleted the feature/default-content-type branch December 31, 2019 16:19
@Greybird
Copy link
Contributor Author

Thanks for the merge, and Happy Holidays.
Would you have an idea of when a new version would be released ? I see not indication on this anywhere.

@SeanFeldman SeanFeldman added this to the 4.1.113 milestone Dec 31, 2019
@SeanFeldman
Copy link
Collaborator

Release 4.1.113 is almost finished. There's one outstanding PR and should be done. Once PR #398 is merged, we can release.

@paolosalvatori
Copy link
Owner

Thanks @Greybird, I was extremely busy in this period, so sorry for the delay. It looks like @ErikMogensen and @SeanFeldman already provided the necessary support here... as usual :)

@SeanFeldman SeanFeldman modified the milestones: 4.1.113, 5.0.0 Nov 3, 2020
@SeanFeldman SeanFeldman mentioned this pull request Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants