Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coloring feature to nodes #468

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

Greybird
Copy link
Contributor

@Greybird Greybird commented Oct 2, 2020

The purpose of this PR is to allow configuring colors for nodes (either leaves or intermediate "directories") based on regular expressions.

Screenshots

Configuration

image

Results

image

@SeanFeldman
Copy link
Collaborator

@ekaliroots
Copy link

Nice feature, we may add style like bold on populated queues too

SeanFeldman
SeanFeldman previously approved these changes Oct 2, 2020
Copy link
Collaborator

@SeanFeldman SeanFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Greybird !

Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature!

Just that minor casing issue.

src/ServiceBusExplorer/Forms/MainForm.cs Outdated Show resolved Hide resolved
@SeanFeldman
Copy link
Collaborator

ErikMogensen
ErikMogensen previously approved these changes Oct 3, 2020
@ErikMogensen
Copy link
Collaborator

@Greybird, I merged the other PR, which you said could adapt. I hope you can fix this PR instead.

@SeanFeldman, apparently you have to approve again when there has been changes to the PR. I think that is new behavior.

@SeanFeldman
Copy link
Collaborator

@ErikMogensen, no worries. I'll let @Greybird address this PR and then re-approve it so that there's no need to do it a 3rd time 😀

@ErikMogensen
Copy link
Collaborator

Sounds good @SeanFeldman 😃

@SeanFeldman
Copy link
Collaborator

@Greybird
Copy link
Contributor Author

Greybird commented Oct 6, 2020

@Greybird, I merged the other PR, which you said could adapt. I hope you can fix this PR instead.

@ErikMogensen, of course, no issue! Thanks for the quick feedback and merge of the other PR!

@ErikMogensen ErikMogensen self-requested a review October 7, 2020 08:27
Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Greybird !

@SeanFeldman SeanFeldman merged commit 879578e into paolosalvatori:develop Oct 7, 2020
@paolosalvatori
Copy link
Owner

paolosalvatori commented Oct 14, 2020

Sorry guys for coming late, I was terribly busy during this period. Thanks @Greybird for the great new feature, this awesome! Thanks @SeanFeldman @ErikMogensen for approving and merging it!

@SeanFeldman SeanFeldman modified the milestones: 4.1.113, 5.0.0 Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants