Re-submit a single message with binary content created with Azure.Messaging.ServiceBus nuget package #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with-azure-messaging-servicebus
KinNeko-De
requested review from
paolosalvatori,
SeanFeldman and
ErikMogensen
as code owners
|
Please provide screen shots of the new GUI parts. |
|
Before: After: Multiple Messages are unchanged: |
ErikMogensen
approved these changes
May 22, 2023
|
Hey.. |
|
No need to do anything @KinNeko-De. I'd prefer if @paolosalvatori or @SeanFeldman also reviewed the PR. |
|
@ErikMogensen Thx :) I was confused because the bot marked my issue as stale and 'wontfix' even if there is an open pull request. |
SeanFeldman
approved these changes
Jun 13, 2023
KinNeko-De
deleted the
feature/binary-compatibility-with-azure-messaging-servicebus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the issue discussed in #712 only occurs when Azure.Messaging.ServiceBus is used.
I added UnitTest to show that the issue does not occur if you use Windows.AzureService.
I failed to reproduce exactly the error. I added a test that somehow emulates the error behavior. I do have not enough knowledge of what was changed between the two APIs. Also, the current Protobuf Nuget Package does not support 4.6.2 so i had to add the Protobuf message as a byte array :(
I ended up adding an additional menu item to resubmit a single message without changing the content.
I reused the code from the resubmit of multiple messages.
But that is just a workaround.
I manually tested re-submitting in Azure ServiceBus Queue and Topic and in both cases DLQ-Messages.
I was not able to manually test Azure Event Grid because I have no test environment.
Finally, I updated NUnit3TestAdapter to the newest version to locally run tests.