Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reth rpc-types import audit #11067

Open
mattsse opened this issue Sep 20, 2024 · 0 comments
Open

reth rpc-types import audit #11067

mattsse opened this issue Sep 20, 2024 · 0 comments
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 20, 2024

Describe the feature

currently the rpc-types crate is just a bunch of re-exports and after #7490 this will even be just re-exports

this crate is pretty beefy and we should discourage importing it, instead reth crates should use the alloy crates directly either via alloy-rpc-types with the necessary features or if only one set of types is required, with the corresponding crate, alloy-rpc-types-eth for example.

TODO

this should be done on multiple prs, similar to #10749

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

No branches or pull requests

2 participants