chore: replace reth-rpc-types by alloy-rpc-types #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
greged93
commented
Sep 20, 2024
| @@ -62,6 +61,7 @@ reth-transaction-pool.workspace = true | |||
| ## ethereum | |||
| alloy-network.workspace = true | |||
| alloy-primitives.workspace = true | |||
| alloy-rpc-types = { workspace = true, features = ["engine"] } | |||
There was a problem hiding this comment.
I could also use alloy-rpc-types-eth, alloy-rpc-types-engine and alloy-serde instead. Don't know how granular you want to get.
mattsse
approved these changes
Sep 20, 2024
| @@ -62,6 +61,7 @@ reth-transaction-pool.workspace = true | |||
| ## ethereum | |||
| alloy-network.workspace = true | |||
| alloy-primitives.workspace = true | |||
| alloy-rpc-types = { workspace = true, features = ["engine"] } | |||
|
sorry very unfortunate timing... we just merged a pr that introduced conflicts |
onbjerg
approved these changes
Sep 21, 2024
mattsse
approved these changes
Sep 21, 2024
|
Will rebase this afternoon! |
|
did it real quick, the latest changes actually made this easier hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
reth-rpc-typesfromreth-node-builder.Linked to #11067.