Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split MevApi trait into two #11036 #11081

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Split MevApi trait into two #11036 #11081

merged 2 commits into from
Sep 22, 2024

Conversation

0xriazaka
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@mattsse mattsse added the A-rpc Related to the RPC implementation label Sep 21, 2024
@mattsse
Copy link
Collaborator

mattsse commented Sep 21, 2024

imports need to be adapted, please dont open prs from your fork main branch

@emhane
Copy link
Member

emhane commented Sep 21, 2024

please dont open prs from your fork main branch

git remote add riazaka git@github.com:0xriazaka/reth.git
git push riazaka

@0xriazaka 0xriazaka closed this Sep 21, 2024
auto-merge was automatically disabled September 21, 2024 19:21

Pull request was closed

@0xriazaka 0xriazaka reopened this Sep 21, 2024
@0xriazaka
Copy link
Contributor Author

please dont open prs from your fork main branch

git remote add riazaka git@github.com:0xriazaka/reth.git git push riazaka

should i do another pr with this way?

@emhane
Copy link
Member

emhane commented Sep 22, 2024

please dont open prs from your fork main branch

git remote add riazaka git@github.com:0xriazaka/reth.git git push riazaka

should i do another pr with this way?

no this was helpful for matze on to how push changes to your main branch :)

@emhane emhane added this pull request to the merge queue Sep 22, 2024
Merged via the queue into paradigmxyz:main with commit f4d11f4 Sep 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants