fix: replace mainnet TTD so geth mainnet genesis parsing works #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 4, 2023
Comment on lines
+82
to
+83
| if raw.contains("58750000000000000000000") && | ||
| !raw.contains("\"58750000000000000000000\"") |
There was a problem hiding this comment.
since we only call this once during launch, this should be fine and this only affects the mainnet ttd
mattsse
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack to make parsing default geth mainnet
genesis.jsonfiles work. This all stems from fundamental limitations ofserde_json, which does not support numbers larger thanu64by default, meaning the TTD cannot be deserialized. This limitation also makesvisit_u128implementations useless. Theoretically this would be solved by using thearbitrary_precisionfeature inserde_json, but that has its own problems, which propagates to users:gakonst/ethers-rs#2206
This replaces the mainnet TTD with the TTD surrounded by quotes, because
JsonU256is able to deserialize strings. This solution does not work for other networks. AFAIK all test networks do not have TTD values larger thanu64, so they do not need this hack in the first place.The hack: