Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include actual close reason in SubscriptionClosed error #504

Merged
merged 1 commit into from
Oct 11, 2021
Merged

include actual close reason in SubscriptionClosed error #504

merged 1 commit into from
Oct 11, 2021

Conversation

niklasad1
Copy link
Member

Closing #485

@niklasad1 niklasad1 changed the title improve SubscriptionClosed error include actual close reason in SubscriptionClosed error Oct 11, 2021
dvdplm
dvdplm approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On a higher level I wonder if closing a subscription should really be treated as an error. I think it'd be better to have a ConnectionState enum with Active, ClientClosed, ServerClosed, Errored variants. But that's a bigger refactoring.

@dvdplm dvdplm merged commit 36bdb85 into master Oct 11, 2021
@dvdplm dvdplm deleted the na-subscription-closed-485 branch October 11, 2021 10:41
@niklasad1
Copy link
Member Author

On a higher level I wonder if closing a subscription should really be treated as an error. I think it'd be better to have a ConnectionState enum with Active, ClientClosed, ServerClosed, Errored variants. But that's a bigger refactoring.

Indeed, you are correct it shouldn't be treated as an error....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@maciejhirsz maciejhirsz maciejhirsz approved these changes

@TarikGul TarikGul Awaiting requested review from TarikGul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @dvdplm @maciejhirsz