Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kad: Providers part 3: publish provider records (start providing) #234

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

kad: Providers part 3: publish provider records (start providing) #234

wants to merge 7 commits into from

Conversation

dmitry-markin
Copy link
Collaborator

@dmitry-markin dmitry-markin commented Sep 3, 2024 •
edited
Loading

Implement ADD_PROVIDER network request and execute FIND_NODE query to publish local provider to the target peers.

Builds upon #200 & #213.

Next PR in the series: #235.

Follow-up

  • Make sure unit and integration tests do not reveal issues and merge together with other PRs in the series.

@dmitry-markin dmitry-markin added the enhancement New feature or request label Sep 3, 2024
@dmitry-markin dmitry-markin self-assigned this Sep 3, 2024
@dmitry-markin dmitry-markin mentioned this pull request Sep 3, 2024
Open
lexnv
lexnv approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one tiny remark wrt open substreams/dial races 👍

Thanks for breaking this up in multiple PRs, make it a lot easier to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

Assignees

@dmitry-markin dmitry-markin

Labels
enhancement New feature or request
Projects
Networking
Status: Code in review 🧐
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitry-markin @lexnv