Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Rialto <> Millau bridges #2663

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Drop Rialto <> Millau bridges #2663

merged 2 commits into from
Nov 1, 2023

Conversation

svyatonik
Copy link
Contributor

We already have some troubles with maintaining those bridges (#2647 (review)).

Since we already have a live setup (Rococo <> Wococo), which will be superseded with Rococo <> Westend bridge soon AND at least we have some basic zombienet tests, I think the time has come to drop Rialto and Millau (and test deployments VM).

Couple of things to mention:

  • also removed several unused subcommands of substrate-relay binary;
  • also removed several scripts that will be unneeded after we'll move to polkadot-sdk;
  • also removed fuzzer that has never been used;
  • left the only docker image that should be built from this repo - the one with substrate-relay binary. We'll need to have a similar build step in polkadot-sdk, but until that, we'll be building it from here.

@svyatonik svyatonik added A-chores Something that has to be done, as part of regular maintenance Monorepo migration Stuff to be done when we migrate to monorepo labels Nov 1, 2023
@svyatonik svyatonik requested a review from a team as a code owner November 1, 2023 08:33
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svyatonik Slava, you should write some condolence speech for Millau and Rialto :(,
Maybe I asked that before, but who and why did choose those names?

Will do the same for `polkadot-staging?

@svyatonik
Copy link
Contributor Author

@svyatonik Slava, you should write some condolence speech for Millau and Rialto :(, Maybe I asked that before, but who and why did choose those names?

Will do the same for `polkadot-staging?

Let's just move forward with that. I think @tomusdrw was behind that :) Just some bridges (https://en.wikipedia.org/wiki/Rialto_Bridge + https://en.wikipedia.org/wiki/Millau_Viaduct)

Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

40K lines fewer to maintain ❤️

@svyatonik svyatonik merged commit ad84cf8 into master Nov 1, 2023
13 checks passed
@svyatonik svyatonik deleted the rip-rialto-millau branch November 1, 2023 19:55
@tomusdrw
Copy link
Contributor

tomusdrw commented Nov 2, 2023

@svyatonik Slava, you should write some condolence speech for Millau and Rialto :(, Maybe I asked that before, but who and why did choose those names?
Will do the same for `polkadot-staging?

Let's just move forward with that. I think @tomusdrw was behind that :) Just some bridges (https://en.wikipedia.org/wiki/Rialto_Bridge + https://en.wikipedia.org/wiki/Millau_Viaduct)

Indeed :)

svyatonik added a commit that referenced this pull request Nov 14, 2023
* drop Rialto <> Millau bridges

* clippy
svyatonik added a commit that referenced this pull request Nov 14, 2023
* drop Rialto <> Millau bridges

* clippy
@Lord-Nymphis Lord-Nymphis mentioned this pull request Jan 12, 2024
18 tasks
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
bkontur pushed a commit that referenced this pull request May 7, 2024
* drop Rialto <> Millau bridges

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance Monorepo migration Stuff to be done when we migrate to monorepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants