Coretime Zombienet test #2867
Merged
Coretime Zombienet test #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `RelaychainDataProvider` to return the latest known relay chain block number in `on_initialize` et all, aka when the `validation_data` wasn't yet set by the inherent.
Currently this only lowers the `TimeslicePeriod` to `10` for faster testing.
… into bkchr-coretime-zombienet
AndWeHaveAPlan
approved these changes
Jan 6, 2024
pepoviola
approved these changes
Jan 6, 2024
pepoviola
reviewed
Jan 6, 2024
Co-authored-by: Javier Viola <javier@parity.io>
seadanda
approved these changes
Jan 8, 2024
| @@ -215,6 +222,9 @@ impl pallet_broker::Config for Runtime { | |||
| type RuntimeEvent = RuntimeEvent; | |||
| type Currency = Balances; | |||
| type OnRevenue = CreditToCollatorPot; | |||
| #[cfg(feature = "fast-runtime")] | |||
| type TimeslicePeriod = ConstU32<10>; | |||
There was a problem hiding this comment.
Just curious why not even lower?
There was a problem hiding this comment.
IDK :D Session length on Rococo local is also around 1 Minute aka 10 blocks.
There was a problem hiding this comment.
Seems as good a reason as any for the tests as they are now.
I was wondering why not e.g. 2 - shorter splittable number, but it would limit the interlacing options when we make more complicated tests.
eskimor
approved these changes
Jan 8, 2024
eskimor
reviewed
Jan 8, 2024
| @@ -247,7 +252,7 @@ fn mk_coretime_call(call: crate::coretime::CoretimeCalls) -> Instruction<()> { | |||
| origin_kind: OriginKind::Superuser, | |||
| // Largest call is set_lease with 1526 byte: | |||
| // Longest call is reserve() with 31_000_000 | |||
| require_weight_at_most: Weight::from_parts(100_000_000, 20_000), | |||
| require_weight_at_most: Weight::from_parts(110_000_000, 20_000), | |||
There was a problem hiding this comment.
Yes. I think 106_000_000 or so was it AFAIR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Zombienet test for Coretime.
Requires: #2862